Skip to content

Commit 81f82b1

Browse files
authored
Merge pull request #323 from YusukeIwaki/driver/1.50.0
Update playwright driver to 1.50.1
2 parents 7a3f758 + 4f1b708 commit 81f82b1

26 files changed

Lines changed: 1290 additions & 234 deletions

.circleci/config.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ jobs:
44
test-remote:
55
docker:
66
- image: cimg/ruby:3.3.0
7-
- image: mcr.microsoft.com/playwright:v1.45.0-jammy
8-
command: /bin/sh -c "cd /home/pwuser ; npx --yes playwright@1.45.0 install && npx playwright@1.45.0 run-server --port 8888 --host 0.0.0.0 --path /ws"
7+
- image: mcr.microsoft.com/playwright:v1.50.1-noble
8+
command: /bin/sh -c "cd /home/pwuser ; npx --yes playwright@1.50.1 install && npx playwright@1.50.1 run-server --port 8888 --host 0.0.0.0 --path /ws"
99
environment:
1010
DEBUG: "pw:*"
1111
user: pwuser

.github/workflows/check.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
- uses: actions/checkout@v3
1111
- uses: ruby/setup-ruby@v1
1212
with:
13-
ruby-version: 3.1
13+
ruby-version: 3.4
1414
bundler-cache: true
1515
- name: Download playwright driver
1616
run: |

.github/workflows/deploy.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
- uses: actions/checkout@v3
1717
- uses: ruby/setup-ruby@v1
1818
with:
19-
ruby-version: 3.1
19+
ruby-version: 3.4
2020
bundler-cache: true
2121
- name: Check Playwright::version
2222
run: bundle exec ruby -e 'raise "invalid Playwright::VERSION" unless Playwright::VERSION == ENV["RELEASE_TAG"]'

.github/workflows/rspec.yml

Lines changed: 70 additions & 69 deletions
Original file line numberDiff line numberDiff line change
@@ -5,103 +5,104 @@ on:
55
paths-ignore:
66
- development/generate_api/example_codes.rb
77
- development/unimplemented_examples.md
8-
- 'documentation/**'
8+
- "documentation/**"
99
- spec/integration/example_spec.rb
1010

1111
jobs:
1212
unit_test:
1313
name: Unit test
1414
runs-on: ubuntu-latest
1515
steps:
16-
- uses: actions/checkout@v3
17-
- uses: ruby/setup-ruby@v1
18-
with:
19-
ruby-version: 3.2
20-
bundler-cache: true
21-
- run: |
22-
rm -rf spec/integration
23-
bundle exec rspec
16+
- uses: actions/checkout@v3
17+
- uses: ruby/setup-ruby@v1
18+
with:
19+
ruby-version: 3.4
20+
bundler-cache: true
21+
- run: |
22+
rm -rf spec/integration
23+
bundle exec rspec
2424
2525
generate_playwright_api:
2626
name: Generate Playwright API codes
2727
runs-on: ubuntu-latest
2828
steps:
29-
- uses: actions/checkout@v3
30-
- uses: ruby/setup-ruby@v1
31-
with:
32-
ruby-version: 3.2
33-
bundler-cache: true
34-
- run: bundle exec ruby development/generate_api.rb
35-
- uses: actions/upload-artifact@v3
36-
with:
37-
name: playwright_api
38-
path: lib/playwright_api
29+
- uses: actions/checkout@v3
30+
- uses: ruby/setup-ruby@v1
31+
with:
32+
ruby-version: 3.4
33+
bundler-cache: true
34+
- run: bundle exec ruby development/generate_api.rb
35+
- uses: actions/upload-artifact@v4
36+
with:
37+
name: playwright_api
38+
path: lib/playwright_api
3939

4040
integration_test_with_npm_playwright_driver:
4141
needs: [unit_test, generate_playwright_api]
4242
strategy:
4343
fail-fast: false
4444
matrix:
45-
ruby_version: [2.7, 3.0, 3.1, 3.2]
45+
ruby_version: [2.7, 3.1, 3.2, 3.3, 3.4]
4646
browser: [chromium, webkit]
4747
name: (${{ matrix.browser }}/Ruby${{ matrix.ruby_version }}) Integration test
4848
runs-on: ubuntu-latest
4949
steps:
50-
- uses: actions/checkout@v3
51-
- uses: ruby/setup-ruby@v1
52-
with:
53-
ruby-version: ${{ matrix.ruby_version }}
54-
bundler-cache: true
55-
- uses: actions/setup-node@v3
56-
with:
57-
node-version: 16
58-
- name: setup ${{ matrix.version }} playwright via npm install
59-
run: |
60-
export PLAYWRIGHT_CLI_VERSION=$(bundle exec ruby -e 'puts Playwright::COMPATIBLE_PLAYWRIGHT_VERSION.strip')
61-
npm install playwright@${PLAYWRIGHT_CLI_VERSION} || npm install playwright@next
62-
./node_modules/.bin/playwright install ${{ matrix.browser }}
63-
./node_modules/.bin/playwright install-deps
64-
- name: Download playwright_api codes
65-
uses: actions/download-artifact@v3
66-
with:
67-
name: playwright_api
68-
path: lib/playwright_api
69-
- run: bundle exec rspec spec/integration --profile 10
70-
env:
71-
BROWSER: ${{ matrix.browser }}
72-
PLAYWRIGHT_CLI_EXECUTABLE_PATH: ./node_modules/.bin/playwright
73-
timeout-minutes: 25
50+
- uses: actions/checkout@v3
51+
- uses: ruby/setup-ruby@v1
52+
with:
53+
ruby-version: ${{ matrix.ruby_version }}
54+
bundler-cache: true
55+
- uses: actions/setup-node@v3
56+
with:
57+
node-version: 22
58+
- name: setup ${{ matrix.version }} playwright via npm install
59+
run: |
60+
export PLAYWRIGHT_CLI_VERSION=$(bundle exec ruby -e 'puts Playwright::COMPATIBLE_PLAYWRIGHT_VERSION.strip')
61+
npm install playwright@${PLAYWRIGHT_CLI_VERSION} || npm install playwright@next
62+
./node_modules/.bin/playwright install ${{ matrix.browser }}
63+
./node_modules/.bin/playwright install-deps
64+
sudo apt-get install -y ffmpeg
65+
- name: Download playwright_api codes
66+
uses: actions/download-artifact@v4
67+
with:
68+
name: playwright_api
69+
path: lib/playwright_api
70+
- run: bundle exec rspec spec/integration --profile 10
71+
env:
72+
BROWSER: ${{ matrix.browser }}
73+
PLAYWRIGHT_CLI_EXECUTABLE_PATH: ./node_modules/.bin/playwright
74+
timeout-minutes: 25
7475

7576
integration_test_with_npm_playwright_driver_and_old_ruby:
7677
needs: [unit_test, generate_playwright_api]
7778
strategy:
7879
fail-fast: false
7980
matrix:
80-
ruby_version: [2.4, 2.5, 2.6]
81+
ruby_version: [2.4, 2.5, 2.6, 3.0]
8182
name: (chromium/Ruby${{ matrix.ruby_version }}) example_spec
8283
runs-on: ubuntu-latest
8384
steps:
84-
- uses: actions/checkout@v3
85-
- uses: ruby/setup-ruby@v1
86-
with:
87-
ruby-version: ${{ matrix.ruby_version }}
88-
bundler-cache: true
89-
- uses: actions/setup-node@v3
90-
with:
91-
node-version: 16
92-
- name: setup ${{ matrix.version }} playwright via npm install
93-
run: |
94-
export PLAYWRIGHT_CLI_VERSION=$(bundle exec ruby -e 'puts Playwright::COMPATIBLE_PLAYWRIGHT_VERSION.strip')
95-
npm install playwright@${PLAYWRIGHT_CLI_VERSION} || npm install playwright@next
96-
./node_modules/.bin/playwright install chromium
97-
./node_modules/.bin/playwright install-deps
98-
- name: Download playwright_api codes
99-
uses: actions/download-artifact@v3
100-
with:
101-
name: playwright_api
102-
path: lib/playwright_api
103-
- run: bundle exec rspec spec/integration/example_spec.rb
104-
env:
105-
BROWSER: chromium
106-
PLAYWRIGHT_CLI_EXECUTABLE_PATH: ./node_modules/.bin/playwright
107-
timeout-minutes: 10
85+
- uses: actions/checkout@v3
86+
- uses: ruby/setup-ruby@v1
87+
with:
88+
ruby-version: ${{ matrix.ruby_version }}
89+
bundler-cache: true
90+
- uses: actions/setup-node@v3
91+
with:
92+
node-version: 22
93+
- name: setup ${{ matrix.version }} playwright via npm install
94+
run: |
95+
export PLAYWRIGHT_CLI_VERSION=$(bundle exec ruby -e 'puts Playwright::COMPATIBLE_PLAYWRIGHT_VERSION.strip')
96+
npm install playwright@${PLAYWRIGHT_CLI_VERSION} || npm install playwright@next
97+
./node_modules/.bin/playwright install chromium
98+
./node_modules/.bin/playwright install-deps
99+
- name: Download playwright_api codes
100+
uses: actions/download-artifact@v4
101+
with:
102+
name: playwright_api
103+
path: lib/playwright_api
104+
- run: bundle exec rspec spec/integration/example_spec.rb
105+
env:
106+
BROWSER: chromium
107+
PLAYWRIGHT_CLI_EXECUTABLE_PATH: ./node_modules/.bin/playwright
108+
timeout-minutes: 10

.github/workflows/windows_check.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@ jobs:
99
uses: actions/checkout@v3
1010
- uses: ruby/setup-ruby@v1
1111
with:
12-
ruby-version: 3.1
12+
ruby-version: 3.4
1313
bundler-cache: true
1414
- uses: actions/setup-node@v3
1515
with:
16-
node-version: 16
16+
node-version: 22
1717
- name: Install playwright driver via npx
1818
run: |
1919
npx playwright@next install chromium

development/CLI_VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.49.0
1+
1.50.1

0 commit comments

Comments
 (0)