Merge phase/19b-release-desktop-installers

Author: YukiCodepth

.github/workflows/desktop-packages.yml

@@ -6,6 +6,9 @@ on:
     tags:
       - "desktop-v*"
 
+permissions:
+  contents: write
+
 jobs:
   build-desktop:
     name: Build ${{ matrix.platform }}
@@ -68,3 +71,17 @@ jobs:
           name: fwb-desktop-${{ matrix.platform }}
           path: desktop/src-tauri/target/release/bundle/**/*
           if-no-files-found: error
+
+      - name: Publish installer to GitHub Release
+        uses: softprops/action-gh-release@v2
+        with:
+          name: Firmware Security Workbench Desktop ${{ github.ref_name }}
+          tag_name: ${{ github.ref_name }}
+          body: |
+            Desktop installer build for Firmware Security Workbench.
+
+            Assets:
+            - macOS: DMG installer
+            - Windows: MSI installer
+            - Linux: DEB package
+          files: desktop/src-tauri/target/release/bundle/**/*

desktop/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "firmware-security-workbench-desktop",
-  "version": "0.4.0",
+  "version": "0.5.0",
   "private": true,
   "type": "module",
   "scripts": {

desktop/package.json

@@ -1,6 +1,6 @@
 [package]
 name = "firmware-security-workbench"
-version = "0.4.0"
+version = "0.5.0"
 description = "Firmware Security Workbench desktop shell"
 authors = ["Firmware Security Workbench Contributors"]
 edition = "2021"

desktop/src-tauri/Cargo.toml

@@ -1,7 +1,7 @@
 {
   "$schema": "https://schema.tauri.app/config/2",
   "productName": "Firmware Security Workbench",
-  "version": "0.4.0",
+  "version": "0.5.0",
   "identifier": "dev.fwb.desktop",
   "build": {
     "beforeDevCommand": "npm run preview",
@@ -28,6 +28,13 @@
   "bundle": {
     "active": true,
     "targets": "all",
+    "icon": [
+      "icons/32x32.png",
+      "icons/128x128.png",
+      "icons/128x128@2x.png",
+      "icons/icon.icns",
+      "icons/icon.ico"
+    ],
     "category": "DeveloperTool",
     "shortDescription": "Firmware analysis desktop workbench",
     "longDescription": "A local-first firmware security analysis desktop shell for scanning firmware, reviewing Risk DNA, and planning hardening actions."

desktop/src-tauri/tauri.conf.json

@@ -58,13 +58,13 @@ The workflow uploads desktop bundle artifacts for each operating system.
 You can also create a desktop package tag. Use a fresh tag for each packaging attempt:
 
 ```bash
-git tag desktop-v0.4.0
-git push origin desktop-v0.4.0
+git tag desktop-v0.5.0
+git push origin desktop-v0.5.0
 ```
 
 ## Packaging Notes
 
-The current desktop app is an alpha shell that talks to the existing FastAPI backend when it is running. The package workflow builds focused release artifacts for macOS (`dmg`), Windows (`msi`), and Linux (`deb`) and regenerates platform icons from `desktop/app-icon.svg` before running Tauri.
+The current desktop app is an alpha shell that talks to the existing FastAPI backend when it is running. The package workflow builds focused release artifacts for macOS (`dmg`), Windows (`msi`), and Linux (`deb`), regenerates platform icons from `desktop/app-icon.svg`, and attaches installers to a GitHub Release for the pushed desktop tag.
 
 The next packaging milestone should bundle the scanner/runtime as a Tauri sidecar so the desktop app is fully self-contained.
 

docs/phase-19-nextgen-ui-packaging.md

@@ -123,16 +123,30 @@ def test_desktop_package_workflow_targets_three_operating_systems(self) -> None:
         self.assertIn("bundle: dmg", workflow)
         self.assertIn("bundle: msi", workflow)
         self.assertIn("bundle: deb", workflow)
+        self.assertIn("permissions:", workflow)
+        self.assertIn("contents: write", workflow)
         self.assertIn("actions/upload-artifact@v4", workflow)
+        self.assertIn("softprops/action-gh-release@v2", workflow)
 
     def test_desktop_build_generates_icons_before_packaging(self) -> None:
         package_json = json.loads(
             (self.repo_root / "desktop" / "package.json").read_text(encoding="utf-8")
         )
-        self.assertEqual(package_json["version"], "0.4.0")
+        self.assertEqual(package_json["version"], "0.5.0")
         self.assertEqual(package_json["scripts"]["prebuild"], "tauri icon app-icon.svg")
         self.assertEqual(package_json["scripts"]["build"], "tauri build")
 
+    def test_tauri_config_declares_platform_icons(self) -> None:
+        config = json.loads(
+            (self.repo_root / "desktop" / "src-tauri" / "tauri.conf.json").read_text(
+                encoding="utf-8"
+            )
+        )
+        icons = config["bundle"]["icon"]
+        self.assertIn("icons/icon.ico", icons)
+        self.assertIn("icons/icon.icns", icons)
+        self.assertIn("icons/128x128.png", icons)
+
 
 if __name__ == "__main__":
     unittest.main()