Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Yubico/java-webauthn-server
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 240b8d937e5aeb6d861625dada77035b49b839bf
Choose a base ref
...
head repository: Yubico/java-webauthn-server
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5d510c55656e7a12e16b746acbd6204168186a3f
Choose a head ref
  • 17 commits
  • 10 files changed
  • 1 contributor

Commits on Sep 3, 2024

  1. Bump org.scalatestplus:junit dependency version

    (git cherry-pick a62d4c8)
    
    Fixes this build failure that suddenly occurred with no code changes:
    
    ```
    $ ./gradlew :webauthn-server-core:compileTestScala
    Execution failed for task ':webauthn-server-core:compileTestScala'.
    >
    bad constant pool index: 0 at pos: 89856
    while compiling: ./webauthn-server-core/src/test/scala/com/yubico/scalacheck/gen/JacksonGenerators.scala
    during phase: globalPhase=typer, enteringPhase=namer
    library version: version 2.13.8
    compiler version: version 2.13.8
    reconstructed args: [9876 characters redacted for brevity]
    
    last tree to typer: Ident(com)
    tree position: line 35 of ./webauthn-server-core/src/test/scala/com/yubico/scalacheck/gen/JacksonGenerators.scala
    tree tpe: com.type
    symbol: final package com
    symbol definition: final package com (a ModuleSymbol)
    symbol package: <none>
    symbol owners: package com
    call site: package gen in package scalacheck in package scalacheck
    
    == Source file context for tree position ==
    
    32 import com.fasterxml.jackson.databind.node.NumericNode
    33 import com.fasterxml.jackson.databind.node.ObjectNode
    34 import com.fasterxml.jackson.databind.node.TextNode
    35 import com.upokecenter.cbor.CBORObject
    36 import com.yubico.internal.util.JacksonCodecs
    37 import org.scalacheck.Arbitrary
    38 import org.scalacheck.Arbitrary.arbitrary
    ```
    emlun committed Sep 3, 2024
    Copy the full SHA
    bfd20d2 View commit details
  2. Bump test dependency versions

    (git cherry-pick f242370)
    emlun committed Sep 3, 2024
    Copy the full SHA
    7a785f7 View commit details
  3. Fix scalafix errors

    (git cherry-pick 3a67ec4)
    
    The `ignoreSourceSets` config is needed to fix errors like this:
    
    ```
    Execution failed for task ':yubico-util:configSemanticDBMain'.
    > Failed to calculate the value of task ':yubico-util:configSemanticDBMain' property 'scalaVersion'.
    > Unable to detect the Scala version for the 'main' source set. Please ensure it declares dependency to scala-library or consider adding it to 'ignoreSourceSets'
    ```
    
    The change to `project-convention-code-formatting-internal.gradle` is needed to fix this error:
    
    ```
    Execution failed for task ':yubico-util-scala:compileScala'.
    > Could not resolve all files for configuration ':yubico-util-scala:detachedConfiguration1'.
       > Could not find org.scalameta:semanticdb-scalac_2.13.13:4.5.5.
         Searched in the following locations:
           - https://repo.maven.apache.org/maven2/org/scalameta/semanticdb-scalac_2.13.13/4.5.5/semanticdb-scalac_2.13.13-4.5.5.pom
         If the artifact you are trying to retrieve can be found in the repository but without metadata in 'Maven POM' format, you need to adjust the 'metadataSources { ... }' of the re
    pository declaration.
         Required by:
             project :yubico-util-scala
    ```
    emlun committed Sep 3, 2024
    Copy the full SHA
    ef12050 View commit details
  4. Bump Gradle scripts to current state on main

    ```
    git checkout 240b8d9 -- build.gradle settings.gradle.kts buildSrc/ */build.gradle.kts
    ```
    emlun committed Sep 3, 2024
    Copy the full SHA
    3920803 View commit details
  5. Copy the full SHA
    bfad3b3 View commit details
  6. Copy the full SHA
    f384e8e View commit details
  7. Copy the full SHA
    d2a0664 View commit details
  8. Copy the full SHA
    533bf0f View commit details
  9. Copy the full SHA
    3aeb20f View commit details
  10. Revert "Run weekly integration test workflow on this branch"

    This reverts commit f384e8e.
    emlun committed Sep 3, 2024
    Copy the full SHA
    d69cee4 View commit details
  11. Copy the full SHA
    48faa74 View commit details
  12. Copy the full SHA
    3abc17d View commit details
  13. Copy the full SHA
    63bc71b View commit details
  14. Merge pull request #376 from Yubico/fido-mds-unknown-fields

    Fix FidoMetadataDownloader failure on unknown properties
    emlun authored Sep 3, 2024
    1
    Copy the full SHA
    67634f8 View commit details
  15. 1
    Copy the full SHA
    a65bb2f View commit details
  16. 1
    Copy the full SHA
    76f9f1a View commit details

Commits on Sep 5, 2024

  1. Release 2.5.3

    `webauthn-server-attestation`:
    
    Fixes:
    
    - `FidoMetadataDownloader` no longer rejects FIDO MDS metadata BLOBs with
      unknown properties.
    emlun committed Sep 5, 2024
    1
    Copy the full SHA
    5d510c5 View commit details
52 changes: 52 additions & 0 deletions .github/workflows/integration-test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
# This name is shown in the status badge in the README
name: integration-test

on:
push:
branches:
- main
- 'release-*'
schedule:
# Run once a week to check compatibility with new FIDO MDS blob contents
- cron: '0 0 * * 1'

jobs:
test:
name: JDK ${{ matrix.java }} ${{ matrix.distribution }}

runs-on: ubuntu-latest
strategy:
matrix:
java: [17]
distribution: [temurin]

outputs:
report-java: 17
report-dist: temurin

steps:
- name: Check out code
uses: actions/checkout@v4

- name: Set up JDK ${{ matrix.java }}
uses: actions/setup-java@v4
with:
java-version: ${{ matrix.java }}
distribution: ${{ matrix.distribution }}

- name: Run integration tests
run: ./gradlew integrationTest

- name: Archive HTML test report
if: ${{ always() }}
uses: actions/upload-artifact@v4
with:
name: test-reports-java${{ matrix.java }}-${{ matrix.distribution }}-html
path: "*/build/reports/**"

- name: Archive JUnit test report
if: ${{ always() }}
uses: actions/upload-artifact@v4
with:
name: test-reports-java${{ matrix.java }}-${{ matrix.distribution }}-xml
path: "*/build/test-results/**/*.xml"
10 changes: 10 additions & 0 deletions NEWS
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
== Version 2.5.3 ==

`webauthn-server-attestation`:

Fixes:

* `FidoMetadataDownloader` no longer rejects FIDO MDS metadata BLOBs with
unknown properties.


== Version 2.5.2 ==

Fixes:
Loading