Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream APIs? #2

Open
j82w opened this issue Mar 9, 2020 · 1 comment
Open

Stream APIs? #2

j82w opened this issue Mar 9, 2020 · 1 comment

Comments

@j82w
Copy link

j82w commented Mar 9, 2020

If you never plan on using the responses the stream APIs do get better performance by avoiding parsing and serialization when it is not necessary.

CosmosDbConnector/src/Facade.CosmosDbSql/Connectors/AzureCosmosDbV3/AzureCosmosDbV3Connector.cs

Line 81 in f5fe891

public async Task<bool> UpdateDocumentAsync<T>(string databaseId, string collectionId, DocumentBase<T> item)

YohanSciubukgian pushed a commit that referenced this issue Apr 3, 2020
Address issue #2 : Use Stream APIs
5b8d190
@YohanSciubukgian YohanSciubukgian mentioned this issue Apr 3, 2020
Open
@YohanSciubukgian
Copy link
Owner

YohanSciubukgian commented Apr 3, 2020 •
edited
Loading

Thanks for your feedbacks.

You are right, I'm not using responses except for getting their status.
I have created a pull request for this issue.
Let me know if it fits your recommendation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@j82w @YohanSciubukgian