-
Notifications
You must be signed in to change notification settings - Fork 726
Geolocation and lock for android mobile device #7289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Unfortunately, we cannot accept this PR because the package.json has been modified with packages that won't work on Linux machines/docker Also u say this works with a fork of the meshagent for Android rather than the official build What might be better is u convert this into a plugin! EDIT: ok, I had a think, we might accept it, but u need to fix the package.json, please, as this will break linux machines! |
|
I restored package.json and package-lock.json as they were previously. For Android, I'm going to check it asap thank you! |
|
Thanks for fixing that! If possible, please can u also apply ur changes to the new modern ui? We aren't really making any major changes to the old ui anymore and we are trying to push people towards the new ui! You can use the new ui by clicking the diamond (top right) and click the bottom 3 lines icon OR by adding |
|
I think there is a typo in default3.handlebars at row 9343: |
|
plz can u resolve these conflicts and we might be merging it!? |
|
just another one, we already use openlayers v4.2.0 |
Restored leaflet style tag and js tag inside generateCustomJSTags and generateCustomCSSTags
|
@si458 I have ported map from leaflet to openlayer. Please consider to remove Content-Security-Policy from webserver.js if that's okay for you: there is an open route for *.openstreetmap. Regarding Custom CSS and JS tags, I placed them under webserver.js with no extra config file modification for using leaflet but, if it's not necessary anymore, consider only last commit. |
|
@mpedy we already add to the CSP IF you have geolocation enabled
|
Added lock option for mobile device and a geolocalization tab for getting position of android mobile device with a fork of MeshCentralAndroidAgent
CLIENT SIDE: Ylianst/MeshCentralAndroidAgent#42