Clean code

Author: Artiom Bozieac

ecommerce-platform-notification-service/src/main/java/com/yashmerino/ecommerce/config/NotificationTemplateConfig.java

@@ -17,7 +17,7 @@
 public class NotificationTemplateConfig {
 
     /**
-     * Implementation of notificaiton templates beans.
+     * Implementation of notification templates bean.
      *
      * @param templates the existing templates.
      *

ecommerce-platform-notification-service/src/main/resources/application.properties

@@ -35,7 +35,3 @@ spring.mail.properties.mail.smtp.starttls.required=true
 spring.mail.properties.mail.smtp.connectiontimeout=5000
 spring.mail.properties.mail.smtp.timeout=5000
 spring.mail.properties.mail.smtp.writetimeout=5000
-
-# Notification retry configuration
-notification.retry.max-attempts=3
-notification.retry.initial-delay=1000

ecommerce-platform-notification-service/src/test/java/com/yashmerino/ecommerce/service/NotificationSenderFactoryTest.java

@@ -32,23 +32,23 @@ void testGetSenderEmailTypeReturnsEmailSender() {
         NotificationSender sender = factory.getSender("email");
 
         assertNotNull(sender);
-        assertTrue(sender instanceof EmailNotificationSender);
+        assertInstanceOf(EmailNotificationSender.class, sender);
     }
 
     @Test
     void testGetSenderEmailUpperCaseReturnsEmailSender() {
         NotificationSender sender = factory.getSender("EMAIL");
 
         assertNotNull(sender);
-        assertTrue(sender instanceof EmailNotificationSender);
+        assertInstanceOf(EmailNotificationSender.class, sender);
     }
 
     @Test
     void testGetSenderEmailMixedCaseReturnsEmailSender() {
         NotificationSender sender = factory.getSender("EmAiL");
 
         assertNotNull(sender);
-        assertTrue(sender instanceof EmailNotificationSender);
+        assertInstanceOf(EmailNotificationSender.class, sender);
     }
 
     @Test

ecommerce-platform-notification-service/src/test/java/com/yashmerino/ecommerce/service/impl/EmailNotificationSenderTest.java

@@ -62,7 +62,7 @@ void testSendSuccess() throws Exception {
     }
 
     @Test
-    void testSendWithHtmlContent() throws Exception {
+    void testSendWithHtmlContent() {
         String contact = "user@example.com";
         NotificationContent content = new NotificationContent(
                 "HTML Subject",
@@ -95,7 +95,7 @@ void testSendHandlesExceptionGracefully() {
     }
 
     @Test
-    void testSendWithEmptyContent() throws Exception {
+    void testSendWithEmptyContent() {
         String contact = "user@example.com";
         NotificationContent content = new NotificationContent("", "");