Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a timeout when extracting pdf highlights #20

Open
vinnyricciardi opened this issue Nov 14, 2017 · 1 comment
Open

Add a timeout when extracting pdf highlights #20

vinnyricciardi opened this issue Nov 14, 2017 · 1 comment

Comments

@vinnyricciardi
Copy link

This is a great and useful project - thanks for making it! I noticed that for certain pdfs Menotexport hangs at extracthl2.extractHighlights2. I fixed a local copy of this script to include a timeout using the Timeout package. It fixed my issue. Would you like me to contribute this addition to your project?

@Xunius
Copy link
Owner

Xunius commented Nov 15, 2017

Thanks for the feedback!

I've seen it slows down sometimes but never seen it hangs, but it would be a good choice to time it out and add the failed pdf to the fail list in such cases. I also think it would be better to set the default time out period to be relatively long as people tend to use this as a one-time tool, so I feel slower execution time is more tolerable than not getting the results. And finally, is it possible to implement this without introducing extra external package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants