AssistFocus - bot doesn't join party1's combat encounter

[anondny]

Description

Hello! Thank you for all the great effort you put into this project and these issues.

I am running into an issue with the AssistFocus mode which may just be my own confusion about its purpose. I have a level 5 mage running Mage_5_Assist.json that follows my own level 5 mage. Some of the basic features of the mode work correctly, the bot will follow me and rebuff me if I lose my Intellect buff, however it doesn't assist me in combat encounters. I am expecting that once I cast my first fireball at a mob and enter combat, the bot will detect its focus is in combat and start a pull/combat sequence on the focus's target.

However when I enter combat the bot will just continuously switch between targeting party1 and party1's target and I believe it doesn't enter the Combat sequence because it itself is not in combat. If I purposefully click off my Int buff while I am in combat, the bot rebuffs me, joining the combat encounter and will start fireballing.

Please let me know if you have any advice, thank you!!

Bot version: c176508

Addon Version

1.7.66

World of Warcraft Client

World of Warcraft Classic

Reproduction Steps

1. Run Mage_5_Assist.json with a mage as party1
2. Have party1 pull a mob
3. Bot doesn't join in the combat encounter

Last Good Version

No response

Screenshots

No response

Logs

assistfocus_problem.log

[anondny]

I have attempted to solve this by creating a macro that does

/assist <player>
/cast fireball

which is pressed when the focus is in combat. this works to enter the bot into combat but feels messy as a solution

  "AssistFocus": {
    "Sequence": [
      {
        "Name": "Arcane Intellect",
        "Key": "5",
        "Requirements": [
          "!F_Arcane Intellect"
        ]
      },
      {
        "Name": "Fireball if Focus in Combat",
        "Key": "7",
        "HasCastBar": true,
        "Requirements": [
          "Mana% > MIN_MANA_FIREBALL%",
          "FocusCombat"
        ]
      }
    ]
  },

+++ b/Core/Requirement/RequirementFactory.cs
@@ -144,7 +144,7 @@ public sealed partial class RequirementFactory

             { AddVisible, npcNameFinder._PotentialAddsExist },
             { "InCombat", bits.Combat },
-
+            { "FocusCombat", bits.FocusTarget_Combat },
             // Range
             { "InMeleeRange", playerReader.IsInMeleeRange },
             { "InCloseMeleeRange", playerReader.InCloseMeleeRange },

[anondny]

Sorry for more ramblings! Once I remove this precondition the behaviour is more expected, after party1 pulls the mob and enters combat, the bot now executes the pull sequence then transitions to the combat sequence.

The bot doesn't start the Pull sequence until the focus initiates combat, which is nice since I don't want the bot to pull an unintended target but it would be a nice touch if the bot could somehow begin the Pull sequence once it maybe detects 1. focushastarget and 2. focus is channeling a hostile spell? The aim here is that the bot will pull at the same time of the focus.

diff --git a/Core/Goals/PullTargetGoal.cs b/Core/Goals/PullTargetGoal.cs
index 2182edf6..fc8b53b8 100644
--- a/Core/Goals/PullTargetGoal.cs
+++ b/Core/Goals/PullTargetGoal.cs
@@ -86,7 +86,11 @@ public sealed class PullTargetGoal : GoapGoal, IGoapEventListener
             }
         }

-        AddPrecondition(GoapKey.targettargetsus, false);
+        if (classConfig.Mode != Mode.AssistFocus)
+        {
+            AddPrecondition(GoapKey.targettargetsus, false);
+        }
+
         AddPrecondition(GoapKey.hastarget, true);
         AddPrecondition(GoapKey.targetisalive, true);
         AddPrecondition(GoapKey.targethostile, true);

[Xian55]

Hello, gooday let me go thru the logs and your messages, i need some time to digest what's going on.

[Xian55]

You are running classic vanilla client

Version: 1.15.6.59415

Where the concept of Focus does not exists so in order to make the Mode AssistFocus work, you have to group up with the other player and have to set the keybind accordingly to the docs.

• Upon entering Assist Focus Goal, the player attempts to target the focus/party1.
• Target Party Member 1 - PageUp key

In the logs i can see the following

[22:18:41:612 I] [GoapAgent        ] New Plan=  Follow Focus
[22:18:41:672 I] [WowProcessInput  ] [PageDown] press random 53ms
[22:18:41:673 V] [ConfigurableInput] [FollowTarget] PageDown pressed 53ms
[22:19:41:246 I] [WowProcessInput  ] [Insert] press random 53ms
[22:19:41:247 V] [ConfigurableInput] [ClearTarget] Insert pressed 53ms
[22:19:41:248 I] [GoapAgent        ] New Plan=  Target Focus Target
[22:19:41:308 I] [WowProcessInput  ] [PageUp] press random 54ms
[22:19:41:308 V] [ConfigurableInput] [TargetFocus] PageUp pressed 54ms
[22:19:41:384 I] [WowProcessInput  ] [PageUp] press random 61ms
[22:19:41:385 V] [ConfigurableInput] [TargetFocus] PageUp pressed 61ms
[22:19:41:447 I] [WowProcessInput  ] [F] press random 51ms
....
.... Cycle between **F** and **FocusTarget**
....

At first glance, the TargetFocusTargetGoal logic seems fine, here's a snippet of it, i think it's quite readable

public override bool CanRun()
{
    if (bits.TargetTarget_PlayerOrPet())
        return false;

    return
        (bits.FocusTarget_Hostile() && bits.FocusTarget_Combat()) ||
        !bits.FocusTarget_Hostile();
}

public override void OnEnter()
{
    input.PressTargetFocus();
    wait.Update();
}

public override void Update()
{
    if (bits.FocusTarget_Hostile())
    {
        if (bits.FocusTarget_Combat())
        {
            input.PressTargetFocus();
            input.PressTargetOfTarget();
        }
    }
    else if (playerReader.SpellInRange.FocusTarget_Trade)
    {
        input.PressTargetFocus();
        input.PressTargetOfTarget();
        input.PressInteract();
    }

    wait.Update();
}

public override void OnExit()
{
    if (!bits.FocusTarget())
    {
        input.PressClearTarget();
        wait.Update();
    }
}

[Xian55]

I have a diff locally, which make it possible what you requested, however i want to conduct tests regarding all cases are covered and i don't introduce any breaking change.

[Xian55]

Uploading diff for later check.

assist_mode_start_cast_asap.patch