Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add tone mapping for rendering thumbnails of HDR videos #20

Open
Klaus1189 opened this issue Mar 26, 2021 · 5 comments
Assignees

Comments

@Klaus1189
Copy link

Klaus1189 commented Mar 26, 2021

I have several HDR videos and the generated thumbnails look washed out.
Is there already a tone map feature available in Icaros? Of so, please let me know how I can enable it.
Otherwise I beg for adding this functionality. It does not have to be super high end tone mapping, just simple, so the picture doesn't look "washed out".

@Xanashi
Copy link
Owner

Xanashi commented Jun 24, 2022

I've looked into this and there currently isn't a good solution available for Icaros,
but I'll be sure to keep an eye out for possible solutions.

@Xanashi Xanashi self-assigned this Oct 22, 2022
@Xanashi Xanashi changed the title Add tone mapping for rendering thumbnails of HDR videos [Feature Request] Add tone mapping for rendering thumbnails of HDR videos Jun 27, 2024
@cafevincent
Copy link

I take it that this is not in 3.3.3 final. Really desperate to get onboard the HDR train but so far I have to re-encode everything to SDR because of this thumbnail issue, or face being left out of the 4k train completely. May I ask about the bad solutions you've considered?

@Xanashi
Copy link
Owner

Xanashi commented Nov 1, 2024

You're correct. HDR is still not supported in Icaros.
When I last commented here, I hadn't found any solutions to adding HDR support.
I'm currently working on a solution with the FFmpeg avfilters: zscale and tonemap.
It's not quite there yet, and I'm still considering other options.

Although it's not a proper solution, it may be easier for you to just take an HDR screenshot of a good frame in the video,
and add it as a cover to the file. That would allow you to have proper colors in your thumbnails and avoid converting your
videos to SDR.

@clsid2
Copy link

clsid2 commented Dec 23, 2024

FFmpeg swscale is currently being rewritten and it looks like it is getting tonemapping ability.

@Xanashi
Copy link
Owner

Xanashi commented Jan 2, 2025

That's incredible news! Thank you for letting me know, I'll be sure to keep an eye on the development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants