Skip to content

Port XQF to GTK+3 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
illwieckz opened this issue Oct 12, 2014 · 11 comments
Open

Port XQF to GTK+3 #14

illwieckz opened this issue Oct 12, 2014 · 11 comments

Comments

@illwieckz
Copy link
Member

This issue must be closed before :

@illwieckz
Copy link
Member Author

@skybon said:

The process is described at https://developer.gnome.org/gtk3/stable/gtk-migrating-2-to-3.html
Depends on: #92

@illwieckz
Copy link
Member Author

#92 is Avoid individual GLib/GTK includes

@Xylemon
Copy link

Xylemon commented Jun 10, 2015

If you do, this can you please keep the option for users to compile a GTK2 version?

@illwieckz
Copy link
Member Author

@skybon, @jmallach , do you think @Xylemon proposal is achievable without much effort or not? (my own opinion is “the smaller the code base is, the best it is”).

@vorot93
Copy link
Contributor

vorot93 commented Jun 10, 2015

@illwieckz I have not looked at GTK3 yet so cannot say for sure.

However, I cannot imagine a strong case for GTK2 since GTK3 is the default in nigh all LTS distributions now.

@illwieckz
Copy link
Member Author

@skybon's PR #147 laid the first GTK3 stone

illwieckz added a commit that referenced this issue Jun 21, 2015
Goodbye Autotools, hello CMake, thanks @skybon, fix #138, fix # 141, fix #148, fix #155, fix #157, ref #14, ref 129, ref #156
@jmallach
Copy link
Contributor

On Wed, Jun 10, 2015 at 02:08:19PM -0700, Thomas Debesse wrote:

@skybon, @jmallach , do you think @Xylemon proposal is achievable without much effort or not? (my own opinion is “the smaller the code base is, the best it is”).

@Xylemon, do you have a good reason to want to keep a GTK2 option? GTK+3
should be available on any distro these days, and the list of benefits is so
long I wouldn't know where to start: HiDPI, Wayland, etc...

Unless there's really a good reason to keep GTK+2 as an option, I would
personally be against it.

Jordi Mallach Pérez -- Debian developer http://www.debian.org/
[email protected] [email protected] http://www.sindominio.net/
GnuPG public key information available at http://oskuro.net/

@illwieckz
Copy link
Member Author

I agree with @jmallach, unless someone comes with an unattended strong reason, I see no need for keeping GTK+2 if we have GTK+3.

@Xylemon
Copy link

Xylemon commented Jun 25, 2015

There are many reasons people would not want to move to GTK3. Some of them are political, it being an out of place program on their systems, and just the general overhead of features that I don't think XQF would ever even utilize to be brutally honest. How would Wayland and HiDPI even be useful? You'd have to do a lot of work in the first place (such as vector images and so on). Not to mention if you really want to support distributions like Slackware, most users aren't going to want to compile a GTK3 only program. In fact almost all SlackBuilds are set up to use GTK2 because the majority of them use KDE or some type of GTK2 system. I still don't see why it would be such a big deal to support GTK2 and GTK3 simultaneously, I mean projects like SpaceFM handle this very well. But if you guys desire to do such a move then I suppose there's nothing I can do.

@vorot93
Copy link
Contributor

vorot93 commented Jun 25, 2015

@Xylemon Current XQF code is barely maintainable and all substantial improvements will be coupled with rewrite. Eventually when GTK3 version is feature complete old parts will be scrapped.

Political reasons (IDONTLIKEIT) cannot substitute the fact that GTK2 is nigh dead. It does not receive any fixes except for security. GTK3 is GNOME's focus and therefore the version to be used by projects.

If anyone of Slackware is willing to step up and do GTK2 backporting of new code then we would have something to talk about. Otherwise it's an additional maintenance burden that I'm very much against.

illwieckz added a commit that referenced this issue Jun 25, 2015
started XQF UI reconstruction, cmake improvements, ref #14
illwieckz added a commit that referenced this issue Jun 27, 2015
port menu to gtkbuilder, move “Preferences” in “Edit” menu, improve GTK+3 stuff etc. ref #14
@illwieckz
Copy link
Member Author

@aufau reported in #222 that GTK2-based XQF does not support desktop scaling, and I reproduced the issue and confirmed that restarting the app after having rescaled it does not fix it. I assume this is a GTK2 issue and the proper fix is to port to GTK3.

xqf-scaling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants