AttributeError: OsmUploadQuestion includes SELECT_QUESTION_EXTRA_FIELDS

[ukanga]

The OSMUploadQuestion includes SELECT_QUESTION_EXTRA_FIELDS which results in an exception when calling the to_json_dict() function for the question. This raises AttributeError exception.

python -m unittest tests.test_osm                                                                                               (pyxform)  ✘ 1 master ✱
.E.
======================================================================
ERROR: test_osm_type_to_json_dict (tests.test_osm.OSMWidgetsTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/ukanga/ona/pyxform/tests/test_osm.py", line 64, in test_osm_type_to_json_dict
    self.assertEqual(osm_question.to_json_dict(), {})
  File "/home/ukanga/ona/pyxform/pyxform/question.py", line 234, in to_json_dict
    result = super().to_json_dict(delete_keys=to_delete)
  File "/home/ukanga/ona/pyxform/pyxform/survey_element.py", line 284, in to_json_dict
    result = self.copy()
  File "/home/ukanga/ona/pyxform/pyxform/survey_element.py", line 276, in copy
    return {k: self[k] for k in self}
  File "/home/ukanga/ona/pyxform/pyxform/survey_element.py", line 276, in <dictcomp>
    return {k: self[k] for k in self}
  File "/home/ukanga/ona/pyxform/pyxform/survey_element.py", line 54, in __getitem__
    return self.__getattribute__(key)
AttributeError: 'OsmUploadQuestion' object has no attribute 'itemset'

----------------------------------------------------------------------
Ran 3 tests in 0.005s

FAILED (errors=1)

This line might be including a typo. I believe what was meant was to use OSM_QUESTION_EXTRA_FIELDS.

[ukanga]

Perhaps not necessary due to the discussion to deprecate the functionality - #745.