Skip to content

Conversation

@shail-mehta
Copy link
Member

@shail-mehta shail-mehta commented Nov 8, 2025

Twenty Ten: 4.5
Twenty Eleven: 5.0
Twenty Twelve: 4.7
Twenty Thirteen: 4.5
Twenty Fourteen: 4.4
Twenty Fifteen: 4.1
Twenty Sixteen: 3.7
Twenty Seventeen: 4.0
Twenty Nineteen: 3.2
Twenty Twenty: 3.0
Twenty Twenty-One: 2.7
Twenty Twenty-Two: 2.1
Twenty Twenty-Three: 1.6
Twenty Twenty-Four: 1.4
Twenty Twenty-Five: 1.4

Trac ticket: #60999

@github-actions
Copy link

github-actions bot commented Nov 8, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @1178653+wordpress-develop-pr-bot[bot]@users.noreply.github.com.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shailu25, mukesh27, sabernhardt, wildworks.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Nov 8, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@shail-mehta shail-mehta changed the title Bundled themes version bumps for WordPress 6.8 Bundled themes version bumps for WordPress 6.9 Nov 8, 2025
@sabernhardt
Copy link

I'm not ready to do a thorough review, but I have two comments.

  • r60934 added package.json and package-lock.json files to Twenty Twenty-Two and Twenty Twenty-Five, and those also need updates to the version number.
  • Twenty Twenty-Three still has no code changes since 1.6. That theme might only have the "Tested up to" version bump, as in r60158, again without packaging a new theme.

@shail-mehta
Copy link
Member Author

All the mentioned feedback has been incorporated in the latest commit.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All theme versions appear to be updated correctly. We also confirmed that no differences occur after running the build script for all themes that have one.

I will also be correcting the date format across all themes (from December 02, 2025 to December 2, 2025).


// Theme block stylesheet.
wp_enqueue_style( 'twentytwelve-block-style', get_template_directory_uri() . '/css/blocks.css', array( 'twentytwelve-style' ), '20240812' );
wp_enqueue_style( 'twentytwelve-block-style', get_template_directory_uri() . '/css/blocks.css', array( 'twentytwelve-style' ), '20251031' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the changeset in which this file was modified: https://core.trac.wordpress.org/changeset/61107

The date currently shows the date the changeset was committed, but should this be changed to the 6.9 release date?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here Last modified date will show.

@t-hamano
Copy link
Contributor

wp_enqueue_style( 'dark', get_template_directory_uri() . '/colors/dark.css', array(), '20240603' );

The dark.css file has been updated with the following changeset:

https://core.trac.wordpress.org/changeset/60960

If we respect the commit date of the changeset, the new string will be 20251017. If we respect the 6.9 release date, it will be 20251202.

@t-hamano
Copy link
Contributor

t-hamano commented Nov 11, 2025

As far as my research goes, that's all the feedback I have. I would appreciate it if someone more knowledgeable could add further reviews.

cc @sabernhardt @peterwilsoncc @desrosj

@shail-mehta
Copy link
Member Author

wp_enqueue_style( 'dark', get_template_directory_uri() . '/colors/dark.css', array(), '20240603' );

The dark.css file has been updated with the following changeset:

https://core.trac.wordpress.org/changeset/60960

If we respect the commit date of the changeset, the new string will be 20251017. If we respect the 6.9 release date, it will be 20251202.

I agree this date should be last modified date. I will update this date.

@t-hamano
Copy link
Contributor

@shail-mehta, The force push may have caused a regression 😅

Released: December 02, 2025 should be Released: December 2, 2025

@shail-mehta
Copy link
Member Author

shail-mehta commented Nov 11, 2025

Yeah I adding it

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I've seen, everything appears to be handled correctly. However, this is my first time being involved in updating a bundled theme, so I welcome additional feedback from other contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants