Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with All-in-one security multisite #297

Closed
AlanJIsaacson opened this issue Jul 16, 2019 · 2 comments
Closed

Conflict with All-in-one security multisite #297

AlanJIsaacson opened this issue Jul 16, 2019 · 2 comments
Labels
Compatibility Compatibility with other plugins, Core, back-compat

Comments

@AlanJIsaacson
Copy link

We have installed and are very happy with the plugin, but have found that its login action priority conflicts with the Wordpress All-In-One security plugin as they both have a priority of 10.

This means we get stuck in an infinite loop of trying to login.

Is it possible to update the line
add_action( 'wp_login', array( CLASS, 'wp_login' ), 10, 2 );
to be
add_action( 'wp_login', array( CLASS, 'wp_login' ), 15, 2 );

Further details https://wordpress.org/support/topic/unable-to-access-console-when-session-expired/

Many thanks in advance

Alan

@kasparsd
Copy link
Collaborator

Thanks for the suggestion @AlanJIsaacson!

I think we could increase the priority of the wp_login hook since we are actually stopping all further execution during the same default priority 10 and some hooks might not even fire. There should be no harm in bumping it to a larger value.

@kasparsd
Copy link
Collaborator

Closing as duplicate of #592 since that better describes the cause and the race condition.

@kasparsd kasparsd closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compatibility Compatibility with other plugins, Core, back-compat
Projects
None yet
Development

No branches or pull requests

3 participants