Writing flow: skip non-empty blocks on arrow key nav#75141
Open
Writing flow: skip non-empty blocks on arrow key nav#75141
Conversation
ellatrix
added
the
[Feature] Writing Flow
|
Size Change: -27 B (0%) Total Size: 3 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
force-pushed
the
try/wf-skip-non-empty-block
branch
from
f4b8970 to
2c5ecb5
Compare
Member
|
I haven't had a chance to test this yet but it'd be nice to get it in before the 7.0 beta. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Previously: #43954.
When navigating by arrow keys, and the block contains any elements that are tabbable, the block wrapper element should be skipped. Example: arrow up from a first list item should select the block before the list, not the list wrapper.
Why?
We should try to emulate writing flow of normal text editors as close as possible.
How?
Just fixes a condition.
Testing Instructions
Arrow up from a first list item should select the block before the list, not the list wrapper. Added an e2e test.
Testing Instructions for Keyboard
Screenshots or screencast