-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Description
Overview
This issue details the current state of typography block support or design tool adoption across all blocks as well as tasks required to fill any gaps. Overall design tool consistency efforts are being tracked via the parent issue: #43241.
Known Issues
- Typography styles applying to block placeholders
- Any block conditionally displaying a
<Warning>within the editor will have text-decoration styles forced upon it unless explicitly omitting the text decoration style before applying the styles its wrapper.text-decorationcannot be reset as per other typography styles.- This will need to be addressed on a block-by-block basis.
- Example PR addressing this problem: Post Comments Count: Prevent text-decoration from affecting warningΒ #43497
- Experimental typography block support APIs should be stabilized
- Once a set "default" configuration is clear for typography supports including what controls show by default, implement shorthand configuration e.g.
"typography": trueor"typography": "default" - The Navigation block applies classes direct to it's
liitems which will conflict with font size classes for the HomeLink block. - Text decoration control is not made available in Global Styles (this is due to past decision we shouldn't encourage such styling at a global level)
Legend
| Value | Description |
|---|---|
| β π | Feature has been adopted and is visible by default control |
| β | Feature has been adopted but is an optional control |
| β | There is a bug or issue with this block support feature's adoption |
| β | Feature has been explicitly opted out of |
| <PR#> | Links to PR adopting the feature for this block |
| - | Feature has not explicitly been adopted/omitted |
| π | Implemented via an ad hoc / bespoke control |
| π§ | Work is in progress towards adopting this feature (no PR yet) |
| π« | Block support will not be adopted for this block |
| β³ | Adoption of block supports is pending block refactoring |
Block Support Adoption
Note: Deprecated blocks have been omitted from this table. e.g. Comment Author Avatar, Post Comment & Text Columns.
| Block | Font Size | Line Height | Font Style | Font Weight | Text Transform | Letter Spacing | Font Family | Text Decoration | Writing Mode |
|---|---|---|---|---|---|---|---|---|---|
| Archives | β π | β | β | β | β | β | β | β | |
| Audio | π« | π« | π« | π« | π« | π« | π« | π« | π« |
| Avatar | π« | π« | π« | π« | π« | π« | π« | π« | π« |
| Button | β π | β | β | β | β | β | β | β | β |
| Buttons | β π | β | β | β | β | β | β | β | |
| Calendar | β π | β | β | β | β | β | β | π« | |
| Categories | β π | β | β | β | β | β | β | β | |
| Code | β π | β | β | β | β | β | β | β | |
| Column | β π | β | β | β | β | β | β | β | |
| Columns | β π | β | β | β | β | β | β | β | |
| Comment Author Name | β π | β | β | β | β | β | β | β | |
| Comment Content | β π | β | β | β | β | β | β | β | |
| Comment Date | β π | β | β | β | β | β | β | β | |
| Comment Edit Link | β π | β | β | β | β | β | β | β | |
| Comment Reply Link | β π | β | β | β | β | β | β | β | |
| Comment Template | β π | β | β | β | β | β | β | β | |
| Comments | β π | β | β | β | β | β | β | β | |
| Comments Pagination | β π | β | β | β | β | β | β | β | |
| Comments Pagination Next | β π | β | β | β | β | β | β | β | |
| Comments Pagination Numbers | β π | β | β | β | β | β | β | β | |
| Comments Pagination Previous | β π | β | β | β | β | β | β | β | |
| Comments Title | β π | β | β π | β π | β | β | β π | β | |
| Cover | β π | β | β | β | β | β | β | β | |
| Details | β π | β | β | β | β | β | β | β | |
| Embed | π« | π« | π« | π« | π« | π« | π« | π« | π« |
| File | - | - | - | - | - | - | - | - | |
| Footnotes | β π | β | β | β | β | β | β | β | β |
| Gallery | π« | π« | π« | π« | π« | π« | π« | π« | π« |
| Group | β π | β | β | β | β | β | β | β | |
| Heading | β π | β | β | β | β | β | β | β | β |
| Home Link - Navigation | β π | β | β | β | β | β | β | β | |
| HTML | π« | π« | π« | π« | π« | π« | π« | π« | π« |
| Image | π« | π« | π« | π« | π« | π« | π« | π« | π« |
| Latest Comments | β π | β | β | β | β | β | β | β | |
| Latest Posts | β π | β | β | β | β | β | β | β | |
| List | β π | β | β | β | β | β | β | β | |
| List Item | β π | β | β | β | β | β | β | β | |
| Login/logout | β π | β | β | β | β | β | β | β | |
| Media & Text | β π | β | β | β | β | β | β | β | |
| More (Read More) | - | - | - | - | - | - | - | - | |
| Navigation | β π | β | β | β | β | β | β | β | |
| Navigation Link | β π | β | β | β | β | β | β | β | |
| Navigation Submenu | - | - | - | - | - | - | - | - | |
| Next Page (Page Break) | - | - | - | - | - | - | - | - | |
| Page List | β π | β | β | β | β | β | β | β | |
| Paragraph | β π | β | β | β | β | β | β | β | β |
| Post Author | β π | β | β | β | β | β | β | β | |
| Post Author Biography | β π | β | β | β | β | β | β | β | |
| Post Author Name | β π | β | β | β | β | β | β | β | |
| Post Comments Count | β π | β | β | β | β | β | β | β | |
| Post Comments Form | β π | β | β | β | β | β | - | - | |
| Post Comments Link | β π | β | β | β | β | β | β | β | |
| Post Content | β π | β | β | β | β | β | β | β | |
| Post Date | β π | β | β | β | β | β | β | β | |
| Post Excerpt | β π | β | β | β | β | β | β | β | |
| Post Featured Image | π« | π« | π« | π« | π« | π« | π« | π« | π« |
| Post Navigation Link | β π | β | β | β | β | β | β | β | β |
| Post Template | β π | β | β | β | β | β | β | β | |
| Post Terms | β π | β | β | β | β | β | β | β | |
| Post Title | β π | β | β | β | β | β | β | β | |
| Preformatted | β π | β | β | β | β | β | β | β | |
| Pullquote | β π | β | β | β | β | β | β | β | |
| Query | π« | π« | π« | π« | π« | π« | π« | π« | π« |
| Query No Results | β π | β | β | β | β | β | β | β | |
| Query Pagination | β π | β | β | β | β | β | β | β | |
| Query Pagination Next | β π | β | β | β | β | β | β | β | |
| Query Pagination Numbers | β π | β | β | β | β | β | β | β | |
| Query Pagination Previous | β π | β | β | β | β | β | β | β | |
| Query Title | β π | β | β | β | β | β | β | β | |
| Query Total | β π | β | β | β | β | β | β | β | |
| Quote | β π | β | β | β | β | β | β | β | |
| Read More | β π | β | β | β | β | β | β | β | |
| RSS | #66991 | #66991 | #66991 | #66991 | #66991 | #66991 | #66991 | #66991 | |
| Search | β π | β | β | β | β | β | β | β | |
| Separator | π« | π« | π« | π« | π« | π« | π« | π« | π« |
| Shortcode | π« | π« | π« | π« | π« | π« | π« | π« | π« |
| Site Logo | π« | π« | π« | π« | π« | π« | π« | π« | π« |
| Site Tagline | β π | β | β | β | β | β | β | β | β |
| Site Title | β π | β | β | β | β | β | β | β | β |
| Social Link | π« | π« | π« | π« | π« | π« | π« | π« | π« |
| Social Links | π« | π« | π« | π« | π« | π« | π« | π« | π« |
| Spacer | π« | π« | π« | π« | π« | π« | π« | π« | π« |
| Table | β π | β | β | β | β | β | β | β | |
| Table of Contents | β π | β | β | β | β | β | β | β | |
| Tag Cloud | π« | β | β | β | β | β | β | π« | |
| Term Description | β π | β | β | β | β | β | β | β | |
| Time To Read | β π | β | β | β | β | β | β | β | |
| Verse | β π | β | β | β | β | β | β | β | β |
| Video | π« | π« | π« | π« | π« | π« | π« | π« | π« |
Merged PRs
The following list details all the PRs merged as part of this effort to increase typography support.
Click to expand list of merged PRs
- Post Title Block: add typography formatting optionsΒ #31623
- Typography block support: add typography support and defaultsΒ #34064
- Post date Block: Add font weight support to the blockΒ #34070
- Post terms: add font weight support to the blockΒ #34142
- [Block Library - Post Navigation Link]: Add typography settingsΒ #35324
- Post Date: Add more typography optionsΒ #35422
- Add fontStyle control to Site Tagline blockΒ #35507
- [Block: Post comment author]: Add link settings and block supportsΒ #35595
- Add the typography support to group/row blocksΒ #37456
- Add font family and text-decoration typography supports to paragraph blocksΒ #39642
- Query page numbers block: add same supports that next/prev page haveΒ #39835
- Post Navigation Link: add design controls (color, text decoration, and font family)Β #41378
- Adds text decoration support to post title blockΒ #42328
- Column Block: Adopt typography supportsΒ #43252
- Columns Block: Add typography supportsΒ #43253
- Categories List: Add typography supportΒ #43254
- Code Block: Add missing typography supports to code blockΒ #43255
- Comment Author Name: Add missing typography supportΒ #43256
- Comments Content: Add missing typography supportΒ #43257
- Comment Date: Add missing typography supportΒ #43262
- Comment Edit Link: Add missing typography supportΒ #43263
- Comments Reply Link: Add missing typography supportΒ #43264
- Comment Template: Adopt typography supportsΒ #43266
- Comments: Add typography supportΒ #43286
- Comments Pagination: Add typography supportΒ #43287
- Comments Pagination Numbers: Add typography supportΒ #43289
- Comments Pagination Next: Add missing typography supportsΒ #43288
- Comments Pagination Previous: Add missing typography supportsΒ #43290
- Comments Title: Add missing typography supportsΒ #43291
- Cover: Add typography supportsΒ #43298
- Home Link: Add typography supportΒ #43307
- Group: Add missing typography supportsΒ #43308
- Latest Comments: Add typography supportΒ #43310
- List: Add missing typography block supportsΒ #43311
- List Item: Adopt typography supportsΒ #43312
- Media & Text: Add typography supportΒ #43314
- Page List: Add typography supportsΒ #43316
- Post Author: Add missing typography supportsΒ #43317
- Post Author Biography: Add missing typography supportΒ #43318
- Post Author Name: Add missing typography supportsΒ #43319
- Post Comments Count: Add missing typography supportsΒ #43321
- Post Comments Link: Add missing typography supportsΒ #43338
- Post Content: Add typography supportsΒ #43339
- Post Date: Add missing typography supportsΒ #43340
- Post Excerpt: Add missing typography supportsΒ #43341
- Post Template: Add typography supportsΒ #43342
- Post Terms: Add missing typography supportsΒ #43343
- Post Navigation Link: Add missing typography supportsΒ #43344
- Preformatted: Add missing typography supportsΒ #43345
- Pullquote: Add missing typography supportsΒ #43346
- Tag Cloud: Add typography supports (except font size)Β #43452
- Search block: Add typography supportsΒ #43499
- Table of Contents: Add typography supportΒ #43509
- Latest Posts: Add typography supportsΒ #43540
- Navigation: Add missing typography supportΒ #43542
- Query No Results: Add typography supportsΒ #43551
- Query Pagination: Add typography supportΒ #43552
- Query Pagination Next: Add missing typography supportsΒ #43555
- Query Pagination Previous: Add missing typography supportsΒ #43556
- Query Pagination Numbers: Add missing typography supportsΒ #43559
- Query Title: Add missing typography supportsΒ #43565
- Quote: Add missing typography supportsΒ #43567
- Term Description: Add missing typography supportsΒ #43568
- Verse: Add missing typography supportsΒ #43569
- Buttons: Add typography supports to button/s blocksΒ #43934
- Archives: Add typography supportΒ #43935
- Calendar: Add typography supports (except text-decoration)Β #43969
- Site Title and Tagline: Add text decoration supportΒ #43972
- Table: Add missing typography supportsΒ #43974
- Heading: Add missing typography supportΒ #44003
- Navigation Link: Add typography supportΒ #44005
- Tag Cloud: Add typography supports (except font size)Β #43452
- Add typography support to time to read blockΒ #49257
- Add Typography: text orientation (writing mode)Β #50822
- Add writing mode support to other blocksΒ #62727
PRs with pending questions, discussions, or concerns
...
Blocks where we're making a conscious decision to skip Typography support
| Block | Reason |
|---|---|
| Audio | Application of typography styles would mess with the balance between the track progress, icons etc |
| Avatar | Avatar's don't have a caption or textual elements to style |
| HTML | While contents of this block might benefit from styling, the custom HTML only gets a wrapper block to apply typography styles to in the editor, which is also wrapped in an iframe sandbox. There are also no guarantees for the custom HTML to have a single wrapping element we could attempt to inject styles into either. |
| Post Feature Image | There's no caption for the post feature image block so typography styles don't make sense here. |
| Separator | Typography styles won't impact this block. |
| Site Logo | Another image block with no caption and therefore no need for typography support |
| Social Link | There's little that would apply from typography styles to this block. Line height might be the only one. Skipping typography support as that might be better handled via a height control/support. Height should also be uniform across children of the parent Social Links block. |
| Social Links | Similar to above. Typography styles don't make a lot of sense on this block. Height would be better handled via a control dedicated to that. |
| Spacer | There's no typography within the block. Height is controlled explicitly so even line-height wouldn't make sense |
Captioned Blocks
There are several blocks which only have a caption as an inner textual element. While it is possible to adopt typography supports for these, there have been explorations towards implementing a Caption block that could be used as an inner block. Adopting typography supports now would likely mean needing to maintain their classes and styles or add extra deprecations should a Caption block land. Additionally, some captioned blocks add their own styles around captions that would override or conflict with those provided by the typography supports.
The current thinking is that we'll postpone any block support adoption here until after 6.1 as that will provide a window to revisit a dedicated Caption block, refactors, and explorations for more complicated blocks such as the Gallery block, which still might benefit from typography supports (so users have a single place to set all the caption styles for its inner images).
The captioned blocks to be revisited after 6.1 are;
- Embed
- Gallery
- Image
- Video
Planned Follow-ups
- Prevent text-decoration block supports from affecting placeholder text.