Skip to content

Block Editor: BlockContext: Opt-in BlockContext component to type checking #21666

@aduth

Description

@aduth

Previously: #21467 (#21467 (comment))
Related: #18838
Blocked by: #21613

Context:

I'd hoped to include a bit of extra type-checking for the new @wordpress/block-editor file in f95972d. Unfortunately, while this worked in my (stale) local branch, dependent types were removed in #21613 as a result of some issues with this week's packages publishing.

Task:

Once the issue associated with #21613 is resolved, reintroduce the changes of 0ff9acda2dee96bf6f571aec27cb917ef664db05.

Note: This commit should have also included the following additional revision:

diff --git a/packages/block-editor/tsconfig.json b/packages/block-editor/tsconfig.json
index 7cd3fd793..61d1d214a 100644
--- a/packages/block-editor/tsconfig.json
+++ b/packages/block-editor/tsconfig.json
@@ -4,6 +4,9 @@
 		"rootDir": "src",
 		"declarationDir": "build-types"
 	},
+	"references": [
+		{ "path": "bin" },
+	],
 	// NOTE: This package is being progressively typed. You are encouraged to
 	// expand this array with files which can be type-checked. At some point in
 	// the future, this can be simplified to an `includes` of `src/**/*`.

It is necessary for all packages referenced by a file to be included in references.

Related documentation: https://github.com/WordPress/gutenberg/blob/master/packages/README.md#using-typescript

Metadata

Metadata

Assignees

Labels

Good First IssueAn issue that's suitable for someone looking to contribute for the first time[Package] Block editor/packages/block-editor[Status] In ProgressTracking issues with work in progress

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions