Skip to content

Commit d3ab3d2

Browse files
committed
SaiderWrapper removed *_with_* methods
1 parent 05dc093 commit d3ab3d2

File tree

2 files changed

+26
-44
lines changed

2 files changed

+26
-44
lines changed

wasm/src/primitives/saider.rs

Lines changed: 11 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,19 @@
11
use std::ops::Deref;
22

3-
use crate::{error::*, ValueWrapper, Wrap};
4-
use cesride_core::{data::Value, Matter, Saider};
53
use js_sys::Array;
64
use wasm_bindgen::prelude::*;
75

6+
use crate::{
7+
error::*,
8+
ValueWrapper,
9+
Wrap
10+
};
11+
use cesride_core::{
12+
data::Value,
13+
Matter,
14+
Saider
15+
};
16+
817
#[wasm_bindgen(js_name = Saider)]
918
#[derive(Clone)]
1019
pub struct SaiderWrapper(pub(crate) Saider);
@@ -111,48 +120,6 @@ impl SaiderWrapper {
111120
Ok(ret)
112121
}
113122

114-
pub fn new_with_sad(
115-
sad: ValueWrapper,
116-
label: Option<String>,
117-
kind: Option<String>,
118-
ignore: Option<Array>,
119-
code: Option<String>,
120-
) -> Result<SaiderWrapper> {
121-
let ignore = ignore
122-
.map(|a| a.iter().map(|v| v.as_string().unwrap_or_default()).collect::<Vec<String>>());
123-
let ignore = ignore.as_deref().map(|a| a.iter().map(String::as_str).collect::<Vec<&str>>());
124-
let ignore = ignore.as_deref();
125-
let saider = Saider::new_with_sad(
126-
&Value::from(sad),
127-
label.as_deref(),
128-
kind.as_deref(),
129-
ignore,
130-
code.as_deref(),
131-
)
132-
.as_js()?;
133-
Ok(SaiderWrapper(saider))
134-
}
135-
136-
pub fn new_with_raw(raw: &[u8], code: Option<String>) -> Result<SaiderWrapper> {
137-
let saider = Saider::new_with_raw(raw, code.as_deref()).as_js()?;
138-
Ok(SaiderWrapper(saider))
139-
}
140-
141-
pub fn new_with_qb64b(qb64b: &[u8]) -> Result<SaiderWrapper> {
142-
let saider = Saider::new_with_qb64b(qb64b).as_js()?;
143-
Ok(SaiderWrapper(saider))
144-
}
145-
146-
pub fn new_with_qb64(qb64: &str) -> Result<SaiderWrapper> {
147-
let saider = Saider::new_with_qb64(qb64).as_js()?;
148-
Ok(SaiderWrapper(saider))
149-
}
150-
151-
pub fn new_with_qb2(qb2: &[u8]) -> Result<SaiderWrapper> {
152-
let saider = Saider::new_with_qb2(qb2).as_js()?;
153-
Ok(SaiderWrapper(saider))
154-
}
155-
156123
pub fn code(&self) -> String {
157124
self.0.code()
158125
}

wasm/tests/test_wasm.rs

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@ use cesride_wasm::BexterWrapper;
77
use cesride_wasm::CesrideMatterCodex;
88
use cesride_wasm::CigarWrapper;
99
use cesride_wasm::DaterWrapper;
10+
use cesride_wasm::SaiderWrapper;
1011
use cesride_wasm::VerferWrapper;
12+
use cesride_wasm::ValueWrapper;
1113

1214
/*
1315
These dater tests are transcriptions from the first two test_dater tests in
@@ -88,3 +90,16 @@ fn test_verfer_convenience() {
8890
assert_eq!(verf_wrapper.qb64b(), verf_wrapper_2.qb64b());
8991
assert_eq!(verf_wrapper.qb2(), verf_wrapper_2.qb2());
9092
}
93+
94+
#[wasm_bindgen_test]
95+
fn test_serder_convenience() {
96+
// TODO implement
97+
}
98+
99+
#[wasm_bindgen_test]
100+
fn test_saider_convenience() {
101+
let sad = r#"{"d":""}"#;
102+
let wrapper = SaiderWrapper::new(Some(ValueWrapper::new(&sad)),
103+
None, None, None, None, None, None, None, None).unwrap();
104+
assert_eq!(wrapper.code(), wrapper.code());
105+
}

0 commit comments

Comments
 (0)