Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Trade league selection #40

Open
Darestr opened this issue Nov 14, 2024 · 2 comments
Open

[Feature request] Trade league selection #40

Darestr opened this issue Nov 14, 2024 · 2 comments

Comments

@Darestr
Copy link

Darestr commented Nov 14, 2024

currently in /frontend/src/lib/skill_tree.ts is being the search generated with current league which is sometimes bugging

export const openTrade = (jewel: number, conqueror: string, results: SearchWithSeed[]) => {
  const url = new URL('https://www.pathofexile.com/trade/search/Necropolis');
  url.searchParams.set('q', JSON.stringify(constructQuery(jewel, conqueror, results)));
  window.open(url, '_blank');
};

Would it be possible to change the link from
"https://www.pathofexile.com/trade/search/Necropolis"

to something like
"https://www.pathofexile.com/trade/search/{league}"

and make an option to select custom leagues based on result from trade API?
https://www.pathofexile.com/developer/docs/reference#leagues

@Darestr Darestr changed the title Trade league selection [Feature request] Trade league selection Nov 14, 2024
@takoz53
Copy link

takoz53 commented Nov 19, 2024

Just was about to open this issue. Necro Settlers is not accessible and user needs to manually always change for every trade. It's really rough. Would be nice of change

@wawel37
Copy link

wawel37 commented Feb 27, 2025

Hi, I see that source code is not up to date, as the live version of the website redirects you to Settlers league search (and it seems it's also hardcoded). The problem is the same for Phrecia event players. The league selection feature would be a bless 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants