fix: correct parameters in surface mesh generation

Author: tobre1

examples/holeEtching/holeEtching.cpp

@@ -94,7 +94,7 @@ int main(int argc, char *argv[]) {
     } else {
       outputFile += suffix;
     }
-    geometry->saveSurfaceMesh(outputFile, true, 0.01, true);
+    geometry->saveSurfaceMesh(outputFile);
   };
 
   std::cout << "Running simulation without intermediate velocity calculation..."

include/viennaps/psDomain.hpp

@@ -469,11 +469,11 @@ VIENNAPS_TEMPLATE_ND(NumericType, D) class Domain {
 
   SmartPointer<viennals::Mesh<NumericType>>
   getSurfaceMesh(bool addInterfaces = false, bool sharpCorners = false,
-                 double wrappingLayerEpsilon = 0.01) const {
+                 double minNodeDistanceFactor = 0.01) const {
     auto mesh = viennals::Mesh<NumericType>::New();
     if (addInterfaces) {
       viennals::ToMultiSurfaceMesh<NumericType, D> meshConverter(
-          mesh, 1e-12, wrappingLayerEpsilon);
+          mesh, minNodeDistanceFactor);
       for (const auto &ls : levelSets_) {
         meshConverter.insertNextLevelSet(ls);
       }
@@ -532,9 +532,9 @@ VIENNAPS_TEMPLATE_ND(NumericType, D) class Domain {
   // Print the top Level-Set (surface) in a VTK file format (vtp).
   void saveSurfaceMesh(const std::string &fileName, bool addInterfaces = true,
                        bool sharpCorners = false,
-                       double wrappingLayerEpsilon = 0.01) const {
+                       double minNodeDistanceFactor = 0.01) const {
     auto mesh =
-        getSurfaceMesh(addInterfaces, sharpCorners, wrappingLayerEpsilon);
+        getSurfaceMesh(addInterfaces, sharpCorners, minNodeDistanceFactor);
     viennals::VTKWriter<NumericType> writer(mesh, fileName);
     writer.setMetaData(metaData_);
     writer.apply();

python/pyWrapDimension.hpp

@@ -538,7 +538,7 @@ template <int D> void bindApi(py::module &module) {
            "Get the level set grids of layers in the domain.")
       .def("getSurfaceMesh", &Domain<T, D>::getSurfaceMesh,
            py::arg("addInterfaces") = false, py::arg("sharpCorners") = false,
-           py::arg("wrappingLayerEpsilon") = 0.01,
+           py::arg("minNodeDistanceFactor") = 0.01,
            "Get the surface mesh of the domain")
       .def("getHullMesh", &Domain<T, D>::getHullMesh,
            py::arg("bottomExtension") = 0.0, py::arg("sharpCorners") = false)
@@ -549,7 +549,7 @@ template <int D> void bindApi(py::module &module) {
       .def("saveSurfaceMesh", &Domain<T, D>::saveSurfaceMesh,
            py::arg("filename"), py::arg("addInterfaces") = false,
            py::arg("sharpCorners") = false,
-           py::arg("wrappingLayerEpsilon") = 1e-2,
+           py::arg("minNodeDistanceFactor") = 0.01,
            "Save the surface of the domain.")
       .def("saveHullMesh", &Domain<T, D>::saveHullMesh, py::arg("filename"),
            py::arg("bottomExtension") = 0.0, py::arg("sharpCorners") = false,

python/viennaps/_core/__init__.pyi

@@ -6,10 +6,10 @@ import collections.abc
 import enum
 import typing
 import viennals._core
-from viennaps import d2
 import viennaps.d2
-import viennaps.d3
+from viennaps import d2
 from viennaps import d3
+import viennaps.d3
 from . import constants
 from . import gpu
 from . import util

python/viennaps/d2/__init__.pyi

@@ -332,7 +332,7 @@ class Domain:
         """
         Get the surface level set.
         """
-    def getSurfaceMesh(self, addInterfaces: bool = False, sharpCorners: bool = False, wrappingLayerEpsilon: typing.SupportsFloat | typing.SupportsIndex = 0.01) -> viennals._core.Mesh:
+    def getSurfaceMesh(self, addInterfaces: bool = False, sharpCorners: bool = False, minNodeDistanceFactor: typing.SupportsFloat | typing.SupportsIndex = 0.01) -> viennals._core.Mesh:
         """
         Get the surface mesh of the domain
         """
@@ -362,7 +362,7 @@ class Domain:
         """
     def saveLevelSets(self, filename: str) -> None:
         ...
-    def saveSurfaceMesh(self, filename: str, addInterfaces: bool = False, sharpCorners: typing.SupportsFloat | typing.SupportsIndex = False, wrappingLayerEpsilon: bool = 0.01) -> None:
+    def saveSurfaceMesh(self, filename: str, addInterfaces: bool = False, sharpCorners: bool = False, minNodeDistanceFactor: typing.SupportsFloat | typing.SupportsIndex = 0.01) -> None:
         """
         Save the surface of the domain.
         """

python/viennaps/d3/__init__.pyi

@@ -332,7 +332,7 @@ class Domain:
         """
         Get the surface level set.
         """
-    def getSurfaceMesh(self, addInterfaces: bool = False, sharpCorners: bool = False, wrappingLayerEpsilon: typing.SupportsFloat | typing.SupportsIndex = 0.01) -> viennals._core.Mesh:
+    def getSurfaceMesh(self, addInterfaces: bool = False, sharpCorners: bool = False, minNodeDistanceFactor: typing.SupportsFloat | typing.SupportsIndex = 0.01) -> viennals._core.Mesh:
         """
         Get the surface mesh of the domain
         """
@@ -362,7 +362,7 @@ class Domain:
         """
     def saveLevelSets(self, filename: str) -> None:
         ...
-    def saveSurfaceMesh(self, filename: str, addInterfaces: bool = False, sharpCorners: typing.SupportsFloat | typing.SupportsIndex = False, wrappingLayerEpsilon: bool = 0.01) -> None:
+    def saveSurfaceMesh(self, filename: str, addInterfaces: bool = False, sharpCorners: bool = False, minNodeDistanceFactor: typing.SupportsFloat | typing.SupportsIndex = 0.01) -> None:
         """
         Save the surface of the domain.
         """