Cross chunk matching

[SimonCropp]

No description provided.

[Copilot]

Pull request overview

This PR refactors the cross-chunk matching logic used by various scrubbers (GuidScrubber, DateScrubber, DirectoryReplacements) into a shared, reusable utility class called CrossChunkMatcher. This eliminates code duplication and provides a consistent approach for matching and replacing patterns that may span across StringBuilder chunk boundaries.

Key Changes

• Introduced CrossChunkMatcher class that provides generic pattern matching across StringBuilder chunks
• Refactored GuidScrubber to use the new CrossChunkMatcher infrastructure
• Refactored DateScrubber to use the new CrossChunkMatcher infrastructure
• Refactored DirectoryReplacements_StringBuilder to use the new CrossChunkMatcher infrastructure

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
CrossChunkMatcher.cs	New shared utility class for matching patterns across StringBuilder chunk boundaries; provides generic ReplaceAll method with callbacks for cross-chunk and within-chunk matching
GuidScrubber.cs	Refactored to use CrossChunkMatcher; removed duplicate FindMatches logic and internal Match struct
DateScrubber.cs	Refactored to use CrossChunkMatcher; replaced ReplaceFixedLength and ReplaceVariableLength methods with CrossChunkMatcher callbacks; renamed parameter from tryConvertDate to tryConvert for consistency
DirectoryReplacements_StringBuilder.cs	Refactored to use CrossChunkMatcher; moved FindMatches logic into callbacks; introduced MatchContext class to encapsulate matching state

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The XML documentation is missing the maxLength parameter. Add a <param name="maxLength"> tag to document this parameter, e.g., <param name="maxLength">Maximum length of patterns to search for</param>.

[SimonCropp]

@copilot open a new pull request to apply changes based on this feedback

[SimonCropp]

@copilot open a new pull request to apply changes based on this feedback

[Copilot]

@SimonCropp I've opened a new pull request, #1651, to work on those changes. Once the pull request is ready, I'll request review from you.

[Copilot]

@SimonCropp I've opened a new pull request, #1652, to work on those changes. Once the pull request is ready, I'll request review from you.