Skip to content

PDB Doesn't correct apply calling convention for fastcall #5761

@plafosse

Description

@plafosse

Version and Platform (required):

  • Binary Ninja Version: 4.1 Stable

Bug Description:
Binary Ninja can properly figure out the difference between stdcall and fastcall in x86 windows binaries. However when debug info is applied at least in this particular case the calling convention is not correctly set.

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

  1. Open the shcore.dll binary shared internally with debug info enabled
  2. Open the same binary again without debug info
  3. View 10024bd0 int32_t __stdcall InlineIsEqualGUID(struct _GUID const& arg1, struct _GUID const& arg2) on both
  4. Observe the calling convention is correct before debug info is applied and incorrect afterward

Metadata

Metadata

Assignees

No one assigned

    Labels

    Component: DebugInfoIssue requires changes to the DebugInfo APIDebugInfo: PDBRelated to parsing PDB filesImpact: MediumIssue is impactful with a bad, or no, workaround

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions