Pluralize GetFilesByPathInProject and get_files_by_path_in_project

Author: spoonmilk

binaryninjaapi.h

@@ -2939,7 +2939,7 @@ namespace BinaryNinja {
 		std::vector<Ref<ProjectFile>> GetFiles() const;
 		Ref<ProjectFile> GetFileById(const std::string& id) const;
 		Ref<ProjectFile> GetFileByPathOnDisk(const std::string& path) const;
-		std::vector<Ref<ProjectFile>> GetFileByPathInProject(const std::string& path) const;
+		std::vector<Ref<ProjectFile>> GetFilesByPathInProject(const std::string& path) const;
 		void PushFile(Ref<ProjectFile> file);
 		bool DeleteFile_(Ref<ProjectFile> file);
 

binaryninjacore.h

@@ -4013,7 +4013,7 @@ extern "C"
 	BINARYNINJACOREAPI BNProjectFile** BNProjectGetFiles(BNProject* project, size_t* count);
 	BINARYNINJACOREAPI BNProjectFile* BNProjectGetFileById(BNProject* project, const char* id);
 	BINARYNINJACOREAPI BNProjectFile* BNProjectGetFileByPathOnDisk(BNProject* project, const char* path);
-	BINARYNINJACOREAPI BNProjectFile** BNProjectGetFileByPathInProject(BNProject* project, const char* path, size_t* count);
+	BINARYNINJACOREAPI BNProjectFile** BNProjectGetFilesByPathInProject(BNProject* project, const char* path, size_t* count);
 
 	BINARYNINJACOREAPI void BNProjectPushFile(BNProject* project, BNProjectFile* file);
 	BINARYNINJACOREAPI bool BNProjectDeleteFile(BNProject* project, BNProjectFile* file);
@@ -4038,7 +4038,7 @@ extern "C"
 	BINARYNINJACOREAPI void BNFreeProjectFile(BNProjectFile* file);
 	BINARYNINJACOREAPI void BNFreeProjectFileList(BNProjectFile** files, size_t count);
 	BINARYNINJACOREAPI char* BNProjectFileGetPathOnDisk(BNProjectFile* file);
-	BINARYNINJACOREAPI char* BNProjectFileGetPathInProject(BNProjectFile* file);
+	BINARYNINJACOREAPI char* BNProjectFileGetPathInProject(const BNProjectFile* file);
 	BINARYNINJACOREAPI bool BNProjectFileExistsOnDisk(BNProjectFile* file);
 	BINARYNINJACOREAPI char* BNProjectFileGetName(BNProjectFile* file);
 	BINARYNINJACOREAPI bool BNProjectFileSetName(BNProjectFile* file, const char* name);

project.cpp

@@ -486,12 +486,12 @@ Ref<ProjectFile> Project::GetFileByPathOnDisk(const std::string& path) const
 }
 
 
-std::vector<Ref<ProjectFile>> Project::GetFileByPathInProject(
+std::vector<Ref<ProjectFile>> Project::GetFilesByPathInProject(
 	const std::string& path
 ) const
 {
 	size_t count;
-	BNProjectFile** files = BNProjectGetFileByPathInProject(m_object, path.c_str(), &count);
+	BNProjectFile** files = BNProjectGetFilesByPathInProject(m_object, path.c_str(), &count);
 
 	std::vector<Ref<ProjectFile>> result;
 	result.reserve(count);

python/project.py

@@ -679,17 +679,17 @@ def get_file_by_path_on_disk(self, path: str) -> Optional[ProjectFile]:
 		file = ProjectFile(handle)
 		return file
 
-	def get_file_by_path_in_project(self, path: str) -> Optional[List[ProjectFile]]:
+	def get_files_by_path_in_project(self, path: str) -> List[ProjectFile]:
 		"""
 		Retrieve a file(s) by path in the project
 		Note that files in a project can share names and paths within the project
 		but are uniquely identified by a disk path or id.
 
 		:param path: Path of the file(s) in the project, separate from their path on disk.
-		:return: List of files with the requested path or None
+		:return: List of files with the requested path
 		"""
 		count = ctypes.c_size_t()
-		value = core.BNProjectGetFileByPathInProject(self._handle, path, count)
+		value = core.BNProjectGetFilesByPathInProject(self._handle, path, count)
 		if value is None:
 			raise ProjectException("Failed to get list of project files by path in project")
 		result = []

rust/tests/binary_view.rs

@@ -106,7 +106,8 @@ fn test_binary_tags() {
     let view = binaryninja::load(out_dir.join("atox.obj")).expect("Failed to create view");
     let tag_ty = view.create_tag_type("Test", "");
     view.add_tag(0x0, &tag_ty, "t", false);
-    view.tag_type_by_name("Test").expect("Failed to get tag type");
+    view.tag_type_by_name("Test")
+        .expect("Failed to get tag type");
 }
 
 // These are the target files present in OUT_DIR