Fix crash on wrapping deeply nested string and improve peformance

Author: spoonmilk

formatter/generic/genericformatter.cpp

@@ -280,12 +280,15 @@ static vector<InstructionTextToken> ParseStringToken(
     vector<InstructionTextToken> result;
     size_t curStart = 0, curEnd = 0;
 
+	string scratch;
+	scratch.reserve(maxParsingLength);
+
     auto ConstructToken = [&](size_t start, size_t end) {
+		scratch.assign(src.data() + start, end - start);
     	InstructionTextToken token = unprocessedStringToken;
-    	const string newTxt = string(src.substr(start, end - start));
-    	token.text = newTxt;
-    	token.width = newTxt.size();
-        result.emplace_back(token);
+    	token.text.swap(scratch);
+    	token.width = token.text.size();
+        result.emplace_back(std::move(token));
     };
 
 	auto flushToken = [&](size_t start, size_t end)
@@ -791,7 +794,7 @@ vector<DisassemblyTextLine> GenericLineFormatter::FormatLines(
 			{
 			case BraceToken:
 				// Beginning of string
-				if (trimmedText == "\"" && currentLine.tokens[tokenIndex + 1].type == StringToken)
+				if (trimmedText == "\"" && tokenIndex + 1 <= currentLine.tokens.size()  && currentLine.tokens[tokenIndex + 1].type == StringToken)
 				{
 					// Create a ContainerContents item and place it onto the item stack. This will hold anything
 					// inside the container once the end of the container is found.
@@ -803,7 +806,7 @@ vector<DisassemblyTextLine> GenericLineFormatter::FormatLines(
 					items.push_back(Item {StartOfContainer, {}, {token}, 0});
 				}
 				// End of string
-				else if (trimmedText == "\"" && currentLine.tokens[tokenIndex - 1].type == StringToken)
+				else if (trimmedText == "\"" && tokenIndex > 0 && currentLine.tokens[tokenIndex - 1].type == StringToken)
 				{
 					items.push_back(Item {EndOfContainer, {}, {token}, 0});
 
@@ -940,7 +943,7 @@ vector<DisassemblyTextLine> GenericLineFormatter::FormatLines(
 		stack<ItemLayoutStackEntry> layoutStack;
 		layoutStack.push({items, additionalContinuationIndentation, desiredWidth, desiredContinuationWidth, desiredStringWidth, false});
 
-		auto newLine = [&](bool forString = false) {
+		auto newLine = [&](const bool forString = false) {
 			if (!firstTokenOfLine)
 			{
 				string lastTokenText = outputLine.tokens.back().text;
@@ -990,10 +993,26 @@ vector<DisassemblyTextLine> GenericLineFormatter::FormatLines(
 			{
 				if (item->type == StringComponent && currentWidth + item->width > desiredStringWidth)
 				{
-					// If a string is too wide to fit on the current line, create a newline
-					// without additional indentation
+					auto next = item;
+					++next;
+
+					if (next != items.end())
+					{
+						layoutStack.push({vector(next, items.end()), additionalContinuationIndentation,
+							desiredWidth, desiredContinuationWidth, desiredStringWidth, false});
+					}
+
 					newLine(true);
-					continue;
+
+					additionalContinuationIndentation += settings.tabWidth;
+					if (desiredContinuationWidth < settings.minimumContentLength + settings.tabWidth)
+						desiredContinuationWidth = settings.minimumContentLength;
+					else
+						desiredContinuationWidth -= settings.tabWidth;
+
+					layoutStack.push({item->items, additionalContinuationIndentation, desiredWidth,
+						desiredContinuationWidth, desiredStringWidth, false});
+					break;
 				}
 				if (currentWidth + item->width > desiredWidth && item->type != StringWhitespace && item->type != StringComponent)
 				{