Disable exception stack traces by default, except for unhandled exceptions during analysis

Author: D0ntPanic

docs/guide/troubleshooting.md

@@ -222,7 +222,7 @@ The following environment variables may be helpful when troubleshooting issues:
 | BN_DISABLE_USER_SETTINGS | Flag (True if exists) | This flag will cause Binary Ninja to ignore any [`settings.json`](https://docs.binary.ninja/guide/settings.html).|
 | BN_SCREENSHOT | Flag (True if exists) | This flag removes some small UI clutter to enable cleaner screenshots. |
 | BN_DEBUG_HTTP | Flag (True if exists) | This flag enables additional debug logging of HTTP activity. |
-| BN_DEBUG_EXCEPTION_TRACES | Flag (Enabled by default, disabled if set to "0") | This variable includes stack traces when exceptions are handled (MacOS and Linux only). |
+| BN_DEBUG_EXCEPTION_TRACES | Flag (Disabled by default, enabled if set to "1") | This variable includes stack traces when exceptions are handled. |
 | BN_DEBUG_CLANG | Flag (True if exists) | If set, this flag adds additional debugging information to stdout from clang type parsing. |
 
 

exceptions.cpp

@@ -32,8 +32,11 @@ BinaryNinja::ExceptionWithStackTrace::ExceptionWithStackTrace(const std::string&
 		if (stackTrace)
 		{
 			m_stackTrace = stackTrace;
-			m_message += "\n";
-			m_message += stackTrace;
+			if (var)
+			{
+				m_message += "\n";
+				m_message += stackTrace;
+			}
 			BNFreeString(stackTrace);
 		}
 	}
@@ -94,8 +97,11 @@ BinaryNinja::ExceptionWithStackTrace::ExceptionWithStackTrace(std::exception_ptr
 		if (stackTrace)
 		{
 			m_stackTrace = stackTrace;
-			m_message += "\n";
-			m_message += stackTrace;
+			if (var)
+			{
+				m_message += "\n";
+				m_message += stackTrace;
+			}
 			BNFreeString(stackTrace);
 		}
 	}