WIP #1160
D0ntPanicAnnotations
10 errors and 1 warning
|
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true:
rust/src/types.rs#L1171
error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> rust/src/types.rs:1171:1
|
1171 | impl Into<ValueLocation> for Variable {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#from_over_into
= note: `-D clippy::from-over-into` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::from_over_into)]`
help: replace the `Into` implementation with `From<variable::Variable>`
|
1171 ~ impl From<Variable> for ValueLocation {
1172 ~ fn from(val: Variable) -> Self {
1173 | ValueLocation {
1174 | components: vec![ValueLocationComponent {
1175 ~ variable: val,
|
|
|
redundant closure:
rust/src/types.rs#L1155
error: redundant closure
--> rust/src/types.rs:1155:18
|
1155 | .map(|component| ValueLocationComponent::into_raw(component))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `ValueLocationComponent::into_raw`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#redundant_closure
|
|
redundant closure:
rust/src/types.rs#L1146
error: redundant closure
--> rust/src/types.rs:1146:22
|
1146 | .map(|component| ValueLocationComponent::from_raw(component))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `ValueLocationComponent::from_raw`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#redundant_closure
= note: `-D clippy::redundant-closure` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::redundant_closure)]`
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
rust/src/types.rs#L1123
error: this expression creates a reference which is immediately dereferenced by the compiler
--> rust/src/types.rs:1123:45
|
1123 | let value_raw = Self::into_rust_raw(&self);
| ^^^^^ help: change this to: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
|
|
this lifetime isn't used in the function definition:
rust/src/types.rs#L842
error: this lifetime isn't used in the function definition
--> rust/src/types.rs:842:9
|
842 | 'a,
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#extra_unused_lifetimes
|
|
this lifetime isn't used in the function definition:
rust/src/types.rs#L791
error: this lifetime isn't used in the function definition
--> rust/src/types.rs:791:21
|
791 | pub fn function<'a, T: Into<ReturnValue>>(
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#extra_unused_lifetimes
= note: `-D clippy::extra-unused-lifetimes` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::extra_unused_lifetimes)]`
|
|
useless conversion to the same type: `binaryninjacore_sys::BNValueLocation`:
rust/src/function.rs#L1099
error: useless conversion to the same type: `binaryninjacore_sys::BNValueLocation`
--> rust/src/function.rs:1099:63
|
1099 | .for_each(|location| ValueLocation::free_rust_raw(location.into()));
| ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `location`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
|
|
useless conversion to the same type: `types::ValueLocation`:
rust/src/function.rs#L1085
error: useless conversion to the same type: `types::ValueLocation`
--> rust/src/function.rs:1085:59
|
1085 | .map(|location| ValueLocation::into_rust_raw(&location.into()))
| ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `location`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
|
|
useless conversion to the same type: `binaryninjacore_sys::BNValueLocation`:
rust/src/function.rs#L1076
error: useless conversion to the same type: `binaryninjacore_sys::BNValueLocation`
--> rust/src/function.rs:1076:63
|
1076 | .for_each(|location| ValueLocation::free_rust_raw(location.into()));
| ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `location`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
|
|
useless conversion to the same type: `types::ValueLocation`:
rust/src/function.rs#L1062
error: useless conversion to the same type: `types::ValueLocation`
--> rust/src/function.rs:1062:59
|
1062 | .map(|location| ValueLocation::into_rust_raw(&location.into()))
| ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `location`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
|
|
licensing
New version for cargo-about available: 0.8.4
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
license
|
26.5 KB |
sha256:a18f75abc726bdaae5db11366ab528e8b24a33c8dff98718bda1ce087b11b5d6
|
|