Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad performance of mana spreaders rendering. #4786

Open
Hunkarada opened this issue Jan 30, 2025 · 1 comment
Open

Bad performance of mana spreaders rendering. #4786

Hunkarada opened this issue Jan 30, 2025 · 1 comment

Comments

@Hunkarada
Copy link

Mod Loader

Fabric

Minecraft Version

1.20.1

Botania version

1.20.1-446

Modloader version

Fabric loader 0.16.9 | API fabric-api-0.92.3+1.20.1

Modpack info

No response

The latest.log file

Issue description

When you have wand of the forest in your hand - you can see preview of spreaders mana burst path. If you have many of spreaders in your base - you always will have HUGE lag, even if you don't look at such previews. Also, many mana spreaders can cause lag by itself, not as strong as in wand of the forest case, but if your base scales - it can become a trouble. Enabling in client config "particles"."powerSystem" makes situation with spreaders better, but you can barely see mana bursts (in my opinion, in optimized particles, there should be only main huge particles, not secondary mini particles, it makes them visible and reduce lag by making less particles in scene rendered, so it's win-win).
Screenshots for each situation here.

Image
Scene without spreaders in real base

Image
Scene with spreaders in real base

Image
Another scene with spreaders

Image
Scene with spreaders with Wand of the Forest

Image
And empty scene without anything but stone as reference fps

All screenshots was made with enabled powerSystem in client config. (optimized particles)

Steps to reproduce

Other information

No response

@Hunkarada
Copy link
Author

Hunkarada commented Jan 30, 2025

Append - screenshot with fps without mana spreaders and without in-game FPS reducer.

Image

What I'm trying to say is - in real world scenario in even little base scale you can feel lag caused by them. I don't have big base, but even by looking at munchdew contraption (1st and 2nd screenshots) I have 3-4x fps drop (they was made with fps limiter, so scene on 1st screen without it can be near 5th screenshot fps). And, forgot to say - I have "staticFlowers" enabled in client config, because, as in case of spreaders with wand in hand, it's HUGE performance drop because of animations of floating flowers. As I can assume - animation processed on CPU, because GPU gets less load with many animated flowers. Mana spreaders have animation of floating cubes inside them. Not sure that they are or not are main reason, just assumption, needs further investigation by profiler or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant