Skip to content

Commit bb161af

Browse files
Merge pull request #1862 from VWS-Python/fix-scipy-errors
Limit scipy version to avoid errors
2 parents 2bb5023 + 1bc81e8 commit bb161af

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

lint.mk

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ fix-ruff:
3030

3131
.PHONY: pip-extra-reqs
3232
pip-extra-reqs:
33-
pip-extra-reqs --skip-incompatible --requirements-file=<(pdm export --pyproject) src/
33+
# Ignore scipy as it is defined to constrain a version.
34+
pip-extra-reqs --ignore-requirement=scipy --skip-incompatible --requirements-file=<(pdm export --pyproject) src/
3435

3536
.PHONY: pip-missing-reqs
3637
pip-missing-reqs:

pyproject.toml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -313,14 +313,15 @@ dependencies = [
313313
"pydantic-settings",
314314
"requests",
315315
"requests-mock",
316+
"scipy<1.12.0", # We pin to an old version of scipy as brisque does not support newer versions. `brisque` appears to be unmaintained, so we may need to switch to an alternative, such as `piq`, which currently does not support Python 3.12.
316317
'tzdata; sys_platform == "win32"',
317318
"vws-auth-tools",
318319
]
319320
[project.optional-dependencies]
320321
dev = [
321322
"check-manifest==0.49",
322-
"dirty-equals==0.7.1.post0", # We pin to an old doc8 to avoid version conflicts with sphinx_toolbox. When we bump this, we can remove doc8.ini.
323-
"doc8==0.11.2",
323+
"dirty-equals==0.7.1.post0",
324+
"doc8==0.11.2", # We pin to an old doc8 to avoid version conflicts with sphinx_toolbox. When we bump this, we can remove doc8.ini.
324325
"docker==7.0.0",
325326
"dodgy==0.2.1",
326327
"enum-tools[sphinx]==0.11",

0 commit comments

Comments
 (0)