Update more tests to handle new response for corrupted images

Author: adamtheturtle

tests/mock_vws/test_flask_app_usage.py

@@ -455,7 +455,7 @@ class TestTargetRaters:
 
     @staticmethod
     def test_default(
-        corrupted_image_file: io.BytesIO,
+        image_file_success_state_low_rating: io.BytesIO,
         high_quality_image: io.BytesIO,
     ) -> None:
         """
@@ -470,10 +470,10 @@ def test_default(
             server_secret_key=database.server_secret_key,
         )
 
-        corrupted_image_target_id = vws_client.add_target(
+        low_rating_image_target_id = vws_client.add_target(
             name=uuid.uuid4().hex,
             width=1,
-            image=corrupted_image_file,
+            image=image_file_success_state_low_rating,
             application_metadata=None,
             active_flag=True,
         )
@@ -487,27 +487,26 @@ def test_default(
         )
 
         for target_id in (
-            corrupted_image_target_id,
+            low_rating_image_target_id,
             high_quality_image_target_id,
         ):
             vws_client.wait_for_target_processed(target_id=target_id)
 
-        corrupted_image_rating = vws_client.get_target_record(
-            target_id=corrupted_image_target_id,
+        low_rated_image_rating = vws_client.get_target_record(
+            target_id=low_rating_image_target_id,
         ).target_record.tracking_rating
 
         high_quality_image_rating = vws_client.get_target_record(
             target_id=high_quality_image_target_id,
         ).target_record.tracking_rating
 
-        # In the real Vuforia, this image may rate as -2.
-        assert corrupted_image_rating <= 0
+        assert low_rated_image_rating <= 0
         assert high_quality_image_rating > 1
 
     @staticmethod
     def test_brisque(
         monkeypatch: pytest.MonkeyPatch,
-        corrupted_image_file: io.BytesIO,
+        image_file_success_state_low_rating: io.BytesIO,
         high_quality_image: io.BytesIO,
     ) -> None:
         """
@@ -524,10 +523,10 @@ def test_brisque(
             server_secret_key=database.server_secret_key,
         )
 
-        corrupted_image_target_id = vws_client.add_target(
+        low_rating_image_target_id = vws_client.add_target(
             name=uuid.uuid4().hex,
             width=1,
-            image=corrupted_image_file,
+            image=image_file_success_state_low_rating,
             application_metadata=None,
             active_flag=True,
         )
@@ -541,21 +540,20 @@ def test_brisque(
         )
 
         for target_id in (
-            corrupted_image_target_id,
+            low_rating_image_target_id,
             high_quality_image_target_id,
         ):
             vws_client.wait_for_target_processed(target_id=target_id)
 
-        corrupted_image_rating = vws_client.get_target_record(
-            target_id=corrupted_image_target_id,
+        low_rated_image_rating = vws_client.get_target_record(
+            target_id=low_rating_image_target_id,
         ).target_record.tracking_rating
 
         high_quality_image_rating = vws_client.get_target_record(
             target_id=high_quality_image_target_id,
         ).target_record.tracking_rating
 
-        # In the real Vuforia, this image may rate as -2.
-        assert corrupted_image_rating <= 0
+        assert low_rated_image_rating <= 0
         assert high_quality_image_rating > 1
 
     @staticmethod

tests/mock_vws/test_target_raters.py

@@ -50,14 +50,15 @@ class TestBrisqueTargetTrackingRater:
     """
 
     @staticmethod
-    def test_low_quality_image(corrupted_image_file: io.BytesIO) -> None:
+    def test_low_quality_image(
+        image_file_success_state_low_rating: io.BytesIO,
+    ) -> None:
         """
         Test that a low quality image returns a low rating.
         """
         rater = BrisqueTargetTrackingRater()
-        image_content = corrupted_image_file.getvalue()
+        image_content = image_file_success_state_low_rating.getvalue()
         rating = rater(image_content=image_content)
-        # In the real Vuforia, this image may rate as -2.
         assert rating == 0
 
     @staticmethod