Feature is still displayed even if the layer is completely removed

[ImMak]

Hi, I'm facing a potential bug.

I'm displaying a graph on top of the map.
The graph is shown using a VectorLayer with features to display vertices and edges.

The map contains only two layers: the TileLayer and the VectorLayer.

A vertex contains a textStyle and circleStyle and if selected the textStyle is replaced with a different color and size to give the look that the selection is active.

An Edge has a strokeStyle (as it is just a line) and if selected the strokeStyle color is changed.

With a click outside the map or on another vertex/edge the previous selected feature turns back to the original style.

Now comes the problem: I want to give to the user the possibility to change the graph based on some options. To do this I remove the VectorLayer and create a new one with a new graph in it but if, before to change the graph, a vertex or an edge has been selected, the highlighted feature remains on the map.

I tried all the possible solutions (to bring back the highlighted feature to not highlighted, to remove the specific feature from the source of the vectorLayer, to remove ALL the layers to check if somehow the feature remained on the TileLayer) but it remains always there. I've also debugged and all the layers are cleared correctly.

Any idea? Am I forgetting something?

[Styp]

Could you provide us with a code snipped? ;)

Its easier to debug if we see what is happening...

[ImMak]

So, these are the default styles for the vertices:

textStyle = new OLStyle();
textStyle.textStyle = new OLTextStyle();
textStyle.textStyle.font = "16px Calibri,sans-serif";
textStyle.textStyle.fill = new OLFillStyle("#FFFFFF");
textStyle.textStyle.stroke = StyleUtils.createDefaultStrokeStyle();
textStyle.textStyle.stroke.color = "#000000";
textStyle.textStyle.stroke.width = 2.5;

circleStyle = new OLStyle();
circleStyle.circleStyle = new OLCircleStyle();
circleStyle.circleStyle.radius = 12.0;
circleStyle.circleStyle.fill = new OLFillStyle();
circleStyle.circleStyle.fill.color = "#FFFF00";
circleStyle.circleStyle.stroke = StyleUtils.createDefaultStrokeStyle();
circleStyle.circleStyle.stroke.color = "000000";
circleStyle.circleStyle.stroke.width = 1.0;

And these are the styles for the highlighted vertices:

highlightedStyle.textStyle.font = "20px Calibri,sans-serif";
highlightedStyle.textStyle.fill.color = "#08AA10";

This is the method called from the selection listener:

protected void updateGraphicalFeatures(final List<String> currentSelectedFeatureIds, final OLVectorSource source, final Boolean isCtrlPressed) {    
    // if there are no selected features (click on empty place of the map) 
    // or is not pressed CTRL it's necessary to clean the previous styles set
    if (currentSelectedFeatureIds.isEmpty() || !isCtrlPressed) {
        cleanAllFeaturePreviouslyAddedInMap(source);
    }

    // highlight the new selected features
    for (String featureId : currentSelectedFeatureIds) {
        OLFeature feature = source.getFeatureById(featureId);
        if (feature != null) {
            highlightSelectedFeature(feature, source);
            source.updateAllFeatures();                 
        }
    }

    myMap.getUI().access(new Runnable() {
        @Override
        public void run() {
            myMap.getUI().push();
        }
    });
}

private void highlightSelectedFeature(OLFeature feature, OLVectorSource source) {
    for (OLStyle style : feature.getStyles()) {
        // vertex
        if (style.textStyle != null) {
            isVertexSelected = Boolean.TRUE;
            if (isEdgeSelected) {
                cleanAllFeaturePreviouslyAddedInMap(source);
                isEdgeSelected = Boolean.FALSE;
            }
        }

        // edge
        if (style.strokeStyle != null) {
            isEdgeSelected = Boolean.TRUE;
            if (isVertexSelected) {
                cleanAllFeaturePreviouslyAddedInMap(source);
                isVertexSelected = Boolean.FALSE;
            }
        }
    }

    // take the style defined above from the map that maps a feature to a list OLStyle
    // (this is done to reuse the same style without recreating them everytime)
    feature.setStyles(featureToHighlightedStylesMap.get(feature));
    selectedFeatures.add(feature);
}

private void cleanAllFeaturePreviouslyAddedInMap(OLVectorSource source) {
    for (OLFeature feature : selectedFeatures) {
        restoreFeatureOriginalProperties(feature);
        source.updateFeature(feature);
    }

    selectedFeatures.clear();
}

This is the piece of code that removes the whole VectorLayer where the graph is drawn
and clear the maps that contains the styles:

myMap.getUI().access(new Runnable() {
    @Override
    public void run() {
        myMap.removeCurrentVectorLayer();
        featureToOriginalStylesMap.clear();
        featureToHighlightedStylesMap.clear();
        myMap.getUI().push();
    }
});

[ImMak]

up, pretty urgent

[mhosio]

OK. Seems to be a "feature" in ol3.js api. The easiest workaround would be to remove the the SelectInteraction from the map, create a new instance of it and add that to the map. This should reset all the ghost selections for you. At least it works in my internal test code. Something like:

`map.removeInteraction(yourSelectInteraction);

yourSelectInteraction = new OLSelectInteraction();

map.addInteraction(yourSelectInteraction);`

[dominicdesu]

I have/had a similar issue:
Having a vectorsource with some features on it, I remove all features the following way:

for (OLFeature feature : vectorSource.getFeatures()) {
    vectorSource.removeFeatureById(feature.getId());
}

and immediately add some other features afterwards:

for (OLFeature feature : newFeatures) {
    vectorSource.addFeature(feature);
}

If no feature is currently selected, this works fine. However, if a feature is selected while the above code is executed, the selected feature is still displayed on the map even though it is not in the newFeatures list.
Only when clicking manually onto the map afterwards, the selected feature disappears.

The workaround provided by @mhosio solved the issue, so thanks for that 👍

[Infiniverse]

Hey @mhosio, I can't get that fix to work for me. If I do something like:

void resetInteraction() {
    assert existing
    map.removeInteraction(existing)

    def dummy = new OLSelectInteraction()
    map.addInteraction(dummy)
    map.removeInteraction(dummy)

    map.addInteraction(existing)
}

The feature still stays selected after deletion, which I'm doing as follows:

void removeFeatureById(long id) {
    def openLayerId = idModel.toOpenLayerId(id)
    if (model.isSelected(openLayerId)) {
        interactions.resetInteraction()
    }
    vectorSource.removeFeatureById(openLayerId)
    idModel.deregister(id)
}

Any ideas?

[mhosio]

You should not add the "existing" back. You really need to create a new one. Swapping with the dummy temporarily does not help.

Matti

Dr Josef Karthauser notifications@github.com kirjoitti 25.10.2016 kello 20.30:

Hey @mhosio, I can't get that fix to work for me. If I do something like:

void resetInteraction() {
assert existing
map.removeInteraction(existing)

def dummy = new OLSelectInteraction()
map.addInteraction(dummy)
map.removeInteraction(dummy)

map.addInteraction(existing)

}
The feature still stays selected after deletion, which I'm doing as follows:

void removeFeatureById(long id) {
def openLayerId = idModel.toOpenLayerId(id)
if (model.isSelected(openLayerId)) {
interactions.resetInteraction()
}
vectorSource.removeFeatureById(openLayerId)
idModel.deregister(id)
}
Any ideas?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[Infiniverse]

That seems wrong. Why is it remembering my existing one?

On 25 Oct 2016, at 22:54, Matti Hosio notifications@github.com wrote:

You should not add the "existing" back. You really need to create a new one. Swapping with the dummy temporarily does not help.

Matti

Dr Josef Karthauser notifications@github.com kirjoitti 25.10.2016 kello 20.30:

Hey @mhosio, I can't get that fix to work for me. If I do something like:

void resetInteraction() {
assert existing
map.removeInteraction(existing)

def dummy = new OLSelectInteraction()
map.addInteraction(dummy)
map.removeInteraction(dummy)

map.addInteraction(existing)
}
The feature still stays selected after deletion, which I'm doing as follows:

void removeFeatureById(long id) {
def openLayerId = idModel.toOpenLayerId(id)
if (model.isSelected(openLayerId)) {
interactions.resetInteraction()
}
vectorSource.removeFeatureById(openLayerId)
idModel.deregister(id)
}
Any ideas?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub #81 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ACpRrvgMvNu-hS1Z7dtw2Fq2nkBY1-m6ks5q3nqmgaJpZM4JwXcY.

[Infiniverse]

I mean, if I have an interaction handler (potentially with a complex repopulated handler wrapped in it, why would I have to reconstruct it just to use it again. ?