fix(style): Use move semantics to pass std::strings

Signed-off-by: Steffen Vogel <[email protected]>

Author: stv0g

include/villas/nodes/opal_orchestra/ddf.hpp

@@ -31,15 +31,14 @@ class Item {
 };
 
 class DataItem : public Item {
-
 public:
   // Config-time members.
   std::string name;
   SignalType type;
   unsigned short length;
   double defaultValue;
 
-  DataItem(const std::string &name) : name(name) {}
+  explicit DataItem(std::string name) : name(std::move(name)) {}
 
   static const unsigned int IDENTIFIER_NAME_LENGTH = 64;
 
@@ -51,7 +50,7 @@ class BusItem : public Item {
   std::unordered_map<std::string, std::shared_ptr<Item>> items;
   std::string name;
 
-  BusItem(const std::string &name) : items(), name(name) {}
+  explicit BusItem(std::string name) : items(), name(std::move(name)) {}
 
   std::shared_ptr<DataItem> upsertItem(std::string_view path, bool &inserted);
 
@@ -63,7 +62,7 @@ class DataSet {
   std::unordered_map<std::string, std::shared_ptr<Item>> items;
   std::string name;
 
-  DataSet(const std::string &name) : items(), name(name) {}
+  explicit DataSet(std::string name) : items(), name(std::move(name)) {}
 
   std::shared_ptr<DataItem> upsertItem(std::string_view path, bool &inserted);
 

lib/nodes/opal_orchestra.cpp

@@ -53,8 +53,8 @@ class OpalOrchestraMapping {
   unsigned int typeSize; // sizeof() of the signal type. See RTSignalType.
   unsigned short length;
 
-  OpalOrchestraMapping(std::shared_ptr<DataItem> item, const std::string &path)
-      : item(item), path(path), signals(), signalList(), indices() {}
+  OpalOrchestraMapping(std::shared_ptr<DataItem> item, std::string path)
+      : item(item), path(std::move(path)), signals(), signalList(), indices() {}
 
   void addSignal(Signal::Ptr signal, std::optional<unsigned> orchestraIdx) {
     if (!orchestraIdx) {