Add signature to subprograms and enum literals.

Author: kraigher

vhdl_lang/src/analysis/analyze.rs

@@ -72,19 +72,6 @@ impl AnalysisError {
     }
 }
 
-/// Converts an AnalysisResult to FatalNullResult
-macro_rules! ok_or_return {
-    ($result:ident, $diagnostics:ident) => {
-        match $result {
-            Ok(value) => value,
-            Err(err) => {
-                err.add_to($diagnostics)?;
-                return Ok(());
-            }
-        }
-    };
-}
-
 pub(super) struct AnalyzeContext<'a> {
     root: &'a DesignRoot,
 
@@ -197,7 +184,7 @@ impl<'a> AnalyzeContext<'a> {
         Ok(())
     }
 
-    fn is_standard_package(&self) -> bool {
+    pub fn is_standard_package(&self) -> bool {
         *self.work_library_name() == self.std_sym
             && *self.current_unit.primary_name() == self.standard_sym
     }

vhdl_lang/src/analysis/declarative.rs

@@ -223,7 +223,7 @@ impl<'a> AnalyzeContext<'a> {
 
         unit.entity_name.set_reference_pos(Some(entity.pos()));
 
-        let mut root_region = Region::with_parent(&entity.result().root_region);
+        let mut root_region = Region::default().with_parent(&entity.result().root_region);
         self.analyze_context_clause(&mut root_region, &mut unit.context_clause, diagnostics)?;
         let mut region = Region::extend(&entity.result().region, Some(&root_region));
 
@@ -266,7 +266,7 @@ impl<'a> AnalyzeContext<'a> {
 
         unit.ident.set_reference_pos(Some(package.pos()));
         // @TODO make pattern of primary/secondary extension
-        let mut root_region = Region::with_parent(&package.result().root_region);
+        let mut root_region = Region::default().with_parent(&package.result().root_region);
         self.analyze_context_clause(&mut root_region, &mut unit.context_clause, diagnostics)?;
 
         let mut region = Region::extend(&package.result().region, Some(&root_region));