Replies: 1 comment
-
@westguard for generic errors there is a DataViewException available for now. But indeed error handling should still be added in multiple places. 👍 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
If an error happens with the
get_data_ids
orget_row_count
methods, perhaps there could be a generic error exception class (similar toDataSourceNotFoundException
orDataNotFoundException
) that can be thrown? I'm thinking if a data source relies on a third party classes, if they throw an exception we should be able to catch those. Perhaps a different solution might be for the API to be able to catch regular exceptions too, for example those thrown by:throw new \Exception( 'Error message' );
If we should be using
DataNotFoundException
for generic errors, let me know.Also, the API seems to be returning a JSON packet if a
DataSourceNotFoundException
orDataNotFoundException
exception is thrown, but there is currently nothing indicating that an error has occurred on the client-side. Perhaps an error notification should be shown?Beta Was this translation helpful? Give feedback.
All reactions