Add dark mode support for course listing page #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! I love your extension and I noticed that it was lacking support for the "Courses" list view for things like hover and locked courses. This page can be found at
https://[canvasurl.tld]/courses, or by selecting "Courses" in the sidebar followed by "All Courses". Your README didn't really have much about contributing missing styles so I just guessed that I was supposed to modify the CSS blob incontent.js, so let me know if I should do something else. Here's the before and after:Hover Effect before:
Hover Effect after:
Disabled courses before:
Disabled courses after:
I tried to do this with the existing variables, namely
--bcbackground-1for the hover effect and disabled courses (the base canvas CSS uses the same background color for these), and--bctext-2for the disabled text, as this was the darkest grey available.I couldn't load and test the extension in Firefox due to the following issues with the manifest v3 migration:
However I did load it in Chromium and it worked as intended.
Let me know if I can change anything to help with this!