Skip to content

Commit 80c8e7b

Browse files
committed
make-unizip: do not use 7z -r (this flag does not do what you think)
The -r option of zip is already implied by 7z, the -r option of 7z does something else, and as the 7z man page says: > (CAUTION: this flag does not do what you think, avoid using it)
1 parent 7c51b3c commit 80c8e7b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

make-unizip

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ done
9393
# Compress symbols
9494
(
9595
cd "${work_dir}"
96-
7z a -tzip -mx=9 -r "unvanquished_${version}/symbols_${version}.zip" symbols
96+
7z a -tzip -mx=9 "unvanquished_${version}/symbols_${version}.zip" symbols
9797
)
9898

9999
# Create (partial) universal zip
@@ -104,7 +104,7 @@ done
104104
rm -v "../unvanquished_${version}.zip"
105105
fi
106106
# Even though almost all the contents are compressed already, it still saves some...
107-
7z a -tzip -mx=9 -r "../unvanquished_${version}.zip" "unvanquished_${version}"
107+
7z a -tzip -mx=9 "../unvanquished_${version}.zip" "unvanquished_${version}"
108108
)
109109

110110
rm -rv "${work_dir}"

0 commit comments

Comments
 (0)