Skip to content

Commit 8a44c7e

Browse files
jfberryFabio1988
authored andcommitted
Change new capability to bool; add some comments
1 parent 3c91276 commit 8a44c7e

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

rotom.proto

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,14 @@ message MitmRequest {
2323
LoginSource source = 2;
2424
bytes token_proto = 3;
2525
string worker_id = 4;
26-
bool enable_compression = 5;
26+
bool enable_compression = 5; // Controller can support compressed responses
2727
}
2828

2929
message RpcRequest {
3030
message SingleRpcRequest {
3131
int32 method = 1;
3232
bytes payload = 2;
33-
bool is_compressed = 3;
33+
bool is_compressed = 3; // This request is compressed
3434
}
3535

3636
repeated SingleRpcRequest request = 1;
@@ -60,16 +60,16 @@ message MitmResponse {
6060
message LoginResponse {
6161
string worker_id = 1;
6262
AuthStatus status = 2;
63-
bool supports_compression = 3;
63+
bool supports_compression = 3; // Agent can support compressed requests
6464
string useragent = 4;
65-
uint64 mitm_capability = 5; // Bitwise field built up of Mitm Capability flags
65+
bool request_long_sessions = 5; // Agent prefers longer sessions over fast reconnects
6666
}
6767

6868
message RpcResponse {
6969
message SingleRpcResponse {
7070
int32 method = 1;
7171
bytes payload = 2;
72-
bool is_compressed = 3;
72+
bool is_compressed = 3; // This payload response is compressed
7373
}
7474

7575
RpcStatus rpc_status = 1;
@@ -132,7 +132,3 @@ enum RpcStatus {
132132
RPC_STATUS_LOGIN_ERROR_BAIL = 20;
133133
RPC_STATUS_MITM_DISALLOWED_REQUEST = 99;
134134
}
135-
136-
enum MitmCapability {
137-
MITM_CAPABILITY_REQUEST_LONG_SESSIONS = 1;
138-
}

0 commit comments

Comments
 (0)