Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nmod:desc for titles #9

Closed
AngledLuffa opened this issue Jan 4, 2025 · 2 comments
Closed

nmod:desc for titles #9

AngledLuffa opened this issue Jan 4, 2025 · 2 comments

Comments

@AngledLuffa
Copy link

for example, things that have been done in PUD

UniversalDependencies/UD_English-PUD@531089e

@AngledLuffa
Copy link
Author

AngledLuffa commented Jan 23, 2025

@nschneid I went through the files and checked for every single title. A couple thousand sentences to read, then a Ssurgeon expression to write.

I have a couple questions before posting it for review:

Henry VIII not an nmod:desc, correct? "For simplicity" according to the nmod_desc page

That King Shakespeare
in
"That King Shakespeare", the essayist Thomas Carlyle wrote in 1840, "does not he shine, in crowned sovereignty, over us all, as the noblest, gentlest, yet strongest of rallying signs;

seems a little sus given the similar nature of That to The, but it wasn't a det relation, so maybe update it to nmod:desc?

"Marxist playwright and director Bertolt Brecht"

original

1       Marxist marxist ADJ     A       Degree=Pos      2       amod    _       _
2       playwright      playwright      NOUN    S       Number=Sing     7       nsubj   _       _
3       and     and     CCONJ   CC      _       4       cc      _       _
4       director        director        NOUN    S       Number=Sing     2       conj    _       _
5       Bertolt Bertolt PROPN   SP      _       4       nmod    _       _
6       Brecht  Brecht  PROPN   SP      _       5       flat    _       _

New? In this proposal, the first title attaches to the person with nmod:desc, and the subsequent one with a conj to the first title

1       Marxist marxist ADJ     A       Degree=Pos      2       amod    _       _
2       playwright      playwright      NOUN    S       Number=Sing     5       nmod:desc   _       _
3       and     and     CCONJ   CC      _       4       cc      _       _
4       director        director        NOUN    S       Number=Sing     2       conj    _       _
5       Bertolt Bertolt PROPN   SP      _       7       nsubj    _       _
6       Brecht  Brecht  PROPN   SP      _       6       flat    _       _

@AngledLuffa AngledLuffa mentioned this issue Jan 23, 2025
@nschneid
Copy link

@nschneid I went through the files and checked for every single title. A couple thousand sentences to read, then a Ssurgeon expression to write.

Awesome!

I have a couple questions before posting it for review:

Henry VIII not an nmod:desc, correct? "For simplicity" according to the nmod_desc page

Yeah, flat

That King Shakespeare in "That King Shakespeare", the essayist Thomas Carlyle wrote in 1840, "does not he shine, in crowned sovereignty, over us all, as the noblest, gentlest, yet strongest of rallying signs;

seems a little sus given the similar nature of That to The, but it wasn't a det relation, so maybe update it to nmod:desc?

It's very unusual to put a demonstrative with a proper personal name. I would probably understand it as [That [King Shakespeare]], with det and nmod:desc, rather than [[That King] Shakespeare] with det and appos. I don't see how "That" could be anything other than det.

"Marxist playwright and director Bertolt Brecht"

original

1       Marxist marxist ADJ     A       Degree=Pos      2       amod    _       _
2       playwright      playwright      NOUN    S       Number=Sing     7       nsubj   _       _
3       and     and     CCONJ   CC      _       4       cc      _       _
4       director        director        NOUN    S       Number=Sing     2       conj    _       _
5       Bertolt Bertolt PROPN   SP      _       4       nmod    _       _
6       Brecht  Brecht  PROPN   SP      _       5       flat    _       _

New? In this proposal, the first title attaches to the person with nmod:desc, and the subsequent one with a conj to the first title

1       Marxist marxist ADJ     A       Degree=Pos      2       amod    _       _
2       playwright      playwright      NOUN    S       Number=Sing     5       nmod:desc   _       _
3       and     and     CCONJ   CC      _       4       cc      _       _
4       director        director        NOUN    S       Number=Sing     2       conj    _       _
5       Bertolt Bertolt PROPN   SP      _       7       nsubj    _       _
6       Brecht  Brecht  PROPN   SP      _       6       flat    _       _

Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants