-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Begin cleaning up some remaining needed ExtPos tags #64
Comments
According to https://universaldependencies.org/en/dep/fixed.html#approximators-quantity-modifiers I don't think it should be |
alright, i took a first pass at this sentence, |
i snuck that in to the current PR while waiting for a review. still a variety of |
If so, I can remove that one here in PUD |
Definitely not |
Should
vs
|
Got it, so rather than treat it as a single MWT, we'll treat the |
btw that analysis doesn't quite work here, since the thing being counted isn't specifically stated. perhaps like this, with just the
--->
|
another option here would be to attach |
Honestly I have never been sure about the policy on approximators or how it should generalize to new expressions. Maybe @amir-zeldes has thoughts? |
In the meantime, call this good for this round of |
Sure |
Is There are a few examples of |
any thoughts on |
I prefer close to as fixed to two case sisters, the "to" doesn't make sense without "close". Either that or do it transparently (i.e. "close" is the head and "to half a million" is obl, but then it's not a nummod anymore).
The problem is that we'd like to keep the fixed list small and closed. I can understand wanting it to be fixed and we could do that, but there will be productive extensions of that. Real example:
|
It's already on there: https://universaldependencies.org/en/dep/fixed.html#approximators-quantity-modifiers Are you suggesting we remove entries?
Well this is marginally attested on the web, but it's not grammatical for me. |
BTW if we're going to extend the approximator list to add "close to" ('approximately') what about "greater than" (similar to "more than"), "in excess of", "in the ballpark of"...seems like it's actually a semi-open class. |
Look at that! I guess ctrl-f failed me where using my own eyes would have worked out better.
Not sure where the line is on how much we can add, but "close to" looks very similar to "up to" |
@nschneid
One of questionable ExtPosness:
up to
It seems kind of similar to
up to 90%
orup to 20,000
which typically gets labeledExtPos=ADV
:The text was updated successfully, but these errors were encountered: