Skip to content

Commit 217fac0

Browse files
Samat Gaynutdinovantipeon
authored andcommitted
fix icon for failed test
1 parent 6d52ff6 commit 217fac0

File tree

5 files changed

+46
-4
lines changed

5 files changed

+46
-4
lines changed

server/src/coverage/TestRunner.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ size_t TestRunner::buildTests(const utbot::ProjectContext& projectContext, const
196196
testsgen::TestStatus TestRunner::runTest(const MakefileUtils::MakefileCommand &command, const std::optional <std::chrono::seconds> &testTimeout) {
197197
auto res = command.run(projectContext.buildDir, true, true, testTimeout);
198198
GTestLogger::log(res.output);
199-
if (StringUtils::contains(res.output, "[ PASSED ]")) {
199+
if (StringUtils::contains(res.output, "[ PASSED ] 1 test")) {
200200
return testsgen::TEST_PASSED;
201201
}
202202
if (StringUtils::contains(res.output, "[ FAILED ] 1 test")) {

server/test/framework/Server_Tests.cpp

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1342,6 +1342,9 @@ namespace {
13421342
ASSERT_FALSE(statusMap.empty());
13431343

13441344
testUtils::checkStatuses(statusMap, tests);
1345+
1346+
StatusCountMap expectedStatusCountMap{{testsgen::TEST_PASSED, 25}};
1347+
testUtils::checkStatusesCount(statusMap, tests, expectedStatusCountMap);
13451348
}
13461349

13471350

@@ -1476,7 +1479,7 @@ namespace {
14761479
buildDirRelativePath, std::move(testFilter));
14771480
auto coverageAndResultsWriter = std::make_unique<ServerCoverageAndResultsWriter>(nullptr);
14781481
CoverageAndResultsGenerator coverageGenerator{ runRequest.get(), coverageAndResultsWriter.get() };
1479-
utbot::SettingsContext settingsContext{ true, true, 15, 0, true, false };
1482+
utbot::SettingsContext settingsContext{ true, true, 45, 0, true, false };
14801483
coverageGenerator.generate(false, settingsContext);
14811484

14821485
ASSERT_TRUE(coverageGenerator.getCoverageMap().empty());
@@ -1486,7 +1489,11 @@ namespace {
14861489

14871490
ASSERT_FALSE(statusMap.empty());
14881491
EXPECT_GT(statusMap.getNumberOfTests(), 2);
1492+
14891493
testUtils::checkStatuses(statusMap, tests);
1494+
1495+
StatusCountMap expectedStatusCountMap{{testsgen::TEST_PASSED, 7}};
1496+
testUtils::checkStatusesCount(statusMap, tests, expectedStatusCountMap);
14901497
}
14911498

14921499
struct ProjectInfo {
@@ -1560,6 +1567,10 @@ namespace {
15601567
statusMap.begin()->second.begin()->second);
15611568
} else {
15621569
testUtils::checkStatuses(statusMap, tests);
1570+
1571+
StatusCountMap expectedStatusCountMap{
1572+
{testsgen::TEST_PASSED, 3}};
1573+
testUtils::checkStatusesCount(statusMap, tests, expectedStatusCountMap);
15631574
}
15641575
}
15651576

server/test/framework/Syntax_Tests.cpp

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2075,7 +2075,7 @@ namespace {
20752075
static auto coverageAndResultsWriter =
20762076
std::make_unique<ServerCoverageAndResultsWriter>(nullptr);
20772077
CoverageAndResultsGenerator coverageGenerator{ runRequest.get(), coverageAndResultsWriter.get() };
2078-
utbot::SettingsContext settingsContext{ true, false, 15, 0, false, false };
2078+
utbot::SettingsContext settingsContext{ true, false, 45, 0, false, false };
20792079
coverageGenerator.generate(false, settingsContext);
20802080

20812081
EXPECT_FALSE(coverageGenerator.hasExceptions());
@@ -2084,6 +2084,7 @@ namespace {
20842084
auto statusMap = coverageGenerator.getTestStatusMap();
20852085
auto tests = coverageGenerator.getTestsToLaunch();
20862086

2087+
// TODO: add checkStatusesCount after linkedlist fix
20872088
testUtils::checkStatuses(statusMap, tests);
20882089
}
20892090

@@ -2117,6 +2118,11 @@ namespace {
21172118
auto tests = coverageGenerator.getTestsToLaunch();
21182119

21192120
testUtils::checkStatuses(statusMap, tests);
2121+
2122+
StatusCountMap expectedStatusCountMap{
2123+
{testsgen::TEST_DEATH, 4},
2124+
{testsgen::TEST_PASSED, 6}};
2125+
testUtils::checkStatusesCount(statusMap, tests, expectedStatusCountMap);
21202126
}
21212127

21222128
TEST_F(Syntax_Test, Simple_parameter_cpp) {

server/test/framework/TestUtils.cpp

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,9 +134,29 @@ namespace testUtils {
134134
void checkStatuses(const Coverage::TestStatusMap &testStatusMap,
135135
const vector<UnitTest> &tests) {
136136
for (auto const &[filename, suitename, testname] : tests) {
137+
if (suitename == tests::Tests::ERROR_SUITE_NAME) {
138+
continue;
139+
}
137140
const auto status = testStatusMap.at(filename).at(testname);
138141
EXPECT_TRUE((testsgen::TestStatus::TEST_PASSED == status) ||
139-
(testsgen::TestStatus::TEST_DEATH == status));
142+
(testsgen::TestStatus::TEST_DEATH == status));
143+
}
144+
}
145+
146+
147+
void checkStatusesCount(const Coverage::TestStatusMap &testStatusMap,
148+
const vector<UnitTest> &tests,
149+
const StatusCountMap &expectedStatusCountMap) {
150+
StatusCountMap actualStatusCountMap;
151+
for (auto const &[filename, suitename, testname] : tests) {
152+
if (suitename == tests::Tests::ERROR_SUITE_NAME) {
153+
continue;
154+
}
155+
const auto status = testStatusMap.at(filename).at(testname);
156+
actualStatusCountMap[status]++;
157+
}
158+
for (const auto& [status, count] : actualStatusCountMap) {
159+
ASSERT_GE(count, expectedStatusCountMap.at(status));
140160
}
141161
}
142162

server/test/framework/TestUtils.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ using Params = const std::vector<shared_ptr<tests::AbstractValueView>> &;
2323
using ReturnValue = const std::shared_ptr<tests::AbstractValueView> &;
2424
using TestCasePredicate = std::function<bool(tests::Tests::MethodTestCase)>;
2525
using CoverageLines = CollectionUtils::MapFileTo<std::set<int>>;
26+
using StatusCountMap = std::unordered_map<testsgen::TestStatus, int>;
2627

2728
namespace testUtils {
2829
using std::function;
@@ -46,6 +47,10 @@ namespace testUtils {
4647

4748
void checkStatuses(const Coverage::TestStatusMap &testStatusMap, const vector<UnitTest> &tests);
4849

50+
void checkStatusesCount(const Coverage::TestStatusMap &testStatusMap,
51+
const vector<UnitTest> &tests,
52+
const StatusCountMap &expectedStatusCountMap);
53+
4954
int getNumberOfTests(const tests::TestsMap &tests);
5055

5156
void checkMinNumberOfTests(const tests::TestsMap &tests, int minNumber);

0 commit comments

Comments
 (0)