Fix of #564 - correct removal of unused positions, fixed tests

Author: tomas-knap

commons-app/src/main/java/cz/cuni/mff/xrg/odcs/commons/app/pipeline/graph/Node.java

@@ -50,7 +50,7 @@ public class Node implements DataObject {
     @JoinColumn(name = "instance_id", unique = true, nullable = false)
     private DPUInstanceRecord dpuInstance;
 
-    @OneToOne(optional = false, cascade = CascadeType.ALL, fetch = FetchType.LAZY)
+    @OneToOne(optional = false, cascade = CascadeType.ALL, orphanRemoval = true, fetch = FetchType.LAZY)
     @JoinColumn(name = "position_id", unique = true)
     private Position position;
 

commons-app/src/test/java/cz/cuni/mff/xrg/odcs/commons/app/constraints/DatabaseConstraintsTest.java

@@ -464,29 +464,30 @@ Object createReferencedInstance(EntityManager em) {
         }.ensureReferencingInstanceDelete(Node.class, DPUInstanceRecord.class);
     }
 
-    @Test
-    public void ON_DELETE_ppl_position_DELETE_ppl_node() {
-        new DeleteConstraintTest() {
-
-            @Override
-            Object createReferencedInstance(EntityManager em) {
-                em.getTransaction().begin();
-                DPUInstanceRecord dpuInstance = new DPUInstanceRecord();
-                Position position = new Position();
-                Node node = new Node();
-                node.setDpuInstance(dpuInstance);
-                node.setPosition(position);
-
-                em.persist(dpuInstance);
-                em.persist(position);
-                em.persist(node);
-
-                em.getTransaction().commit();
-                return position;
-            }
-
-        }.ensureReferencingInstanceDelete(Node.class, Position.class);
-    }
+    // Note: the test is not needed, ppl_node is removed, ppl_position is dependant class
+    //    @Test
+    //    public void ON_DELETE_ppl_position_DELETE_ppl_node() {
+    //        new DeleteConstraintTest() {
+    //
+    //            @Override
+    //            Object createReferencedInstance(EntityManager em) {
+    //                em.getTransaction().begin();
+    //                DPUInstanceRecord dpuInstance = new DPUInstanceRecord();
+    //                Position position = new Position();
+    //                Node node = new Node();
+    //                node.setDpuInstance(dpuInstance);
+    //                node.setPosition(position);
+    //
+    //                em.persist(dpuInstance);
+    //                em.persist(position);
+    //                em.persist(node);
+    //
+    //                em.getTransaction().commit();
+    //                return position;
+    //            }
+    //
+    //        }.ensureReferencingInstanceDelete(Node.class, Position.class);
+    //    }
 
     @Test
     public void ON_DELETE_ppl_graph_DELETE_ppl_edge() {