Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider combining workspace sharing and auth domain audits into a single audit #915

Open
amstilp opened this issue Feb 3, 2025 · 0 comments

Comments

@amstilp
Copy link
Contributor

amstilp commented Feb 3, 2025

Instead of having a separate view (and class?) for workspace sharing audits and auth domain membership audits, it might be possible to run both audits in one. This would also make it easier to add other audits, like checking for requester pays (except that doesn't have a group).

Considerations:

  • The audit class for a workspace type would run both a sharing audit and an auth domain membership audit for each workspace.
  • The results classes know how to handle their results, so we would just have to call the handle() method somewhere.
  • Tables would have to chance somehow: in the sharing case the table shows access level and compute status, and in the auth domain case it shows role. It would be less straightforward to combine these into a single table.
  • The way that we showing the "action" button in the table would need to change because right now the view we are accessing is hardcoded into the template. This could probably be updated by adding a method or attribute that gets the view responsible for handling the action (e.g., "get_handle_view_name" or "handle_view_name"), and using that in the template or table.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant