Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Use grade highlight colors on compare #263

Open
TyHil opened this issue Oct 16, 2024 · 2 comments
Open

[Feature Request] Use grade highlight colors on compare #263

TyHil opened this issue Oct 16, 2024 · 2 comments
Assignees
Labels
Type: Feature Request New feature or request

Comments

@TyHil
Copy link
Member

TyHil commented Oct 16, 2024

Overview

We have 2 arrays of colors we use on the LHS, depending on whether the user is on dark or light mode. However, the compare component uses a dynamic range of colors from #00FF00 to #FF0000.

Proposal

Update the compare component to use the dark/light arrays of colors. Either just do a gradient between the first and last color or somehow use all the colors in the array.

@TyHil TyHil added the Type: Feature Request New feature or request label Oct 16, 2024
@AbhiramTadepalli
Copy link
Contributor

@TyHil is this still active?

@TyHil
Copy link
Member Author

TyHil commented Nov 20, 2024

Yes, you can see how these colors are not the same
Screenshot_20241119_185809_Firefox~2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants