Merge branch 'main' of https://github.com/kedlaya-s-algorithm-research/griffiths-dwork-construction

Author: MaximusMellberg

Project.toml

@@ -1,5 +1,6 @@
 name = "DeRham"
 uuid = "0ea6bb9e-09b2-4dc0-b975-f97753fde228"
+version = "0.1.0"
 
 [deps]
 BitIntegers = "c3b6d118-76ef-56ca-8cc7-ebb389d030a1"

src/ControlledReduction.jl

@@ -64,7 +64,9 @@ function my_addmul!(A::zzModMatrix, B::zzModMatrix, C::UInt, D::zzModMatrix)
 end
 
 function my_mul!(A::zzModMatrix, B::zzModMatrix, c)
-    c = UInt(c)
+    p = characteristic(base_ring(parent(A)))
+    ui(i) = 0 ≤ i ? UInt(i) : UInt(i + p)
+    c = ui(c)
     @ccall Oscar.Nemo.libflint.nmod_mat_scalar_mul(A::Ref{zzModMatrix},
                                                    B::Ref{zzModMatrix},
                                                    c::UInt)::Nothing
@@ -1096,6 +1098,8 @@ function precomputeRuvs(S,f,pseudoInverseMat,Ruvs,explookup,params)
 end
 
 function computeRuv(V,S,f,pseudoInverseMat,Ruvs,explookup,params)
+    vars_reversed = params.vars_reversed
+    termorder = params.termorder
     n = nvars(parent(f)) - 1
     d = total_degree(f)
     R = coefficient_ring(parent(f))