Skip to content

SPECTUB seem to set first LOR in each view to empty #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KrisThielemans opened this issue Mar 16, 2025 · 0 comments
Open

SPECTUB seem to set first LOR in each view to empty #1576

KrisThielemans opened this issue Mar 16, 2025 · 0 comments

Comments

@KrisThielemans
Copy link
Collaborator

KrisThielemans commented Mar 16, 2025

ProjMatrixByBin::get_proj_matrix_elems_for_one_bin checks if the LOR is in the cache, and if not it will call calculate_proj_matrix_elems_for_one_bin (and then store it in the cache, if caching is on).

ProjMatrixByBinSPECTUB::calculate_proj_matrix_elems_for_one_bin should fill in the LOR passes as argument. However, it doesn't:

The same problem occurs for PinholeSPECTUB (as the code is (nearly?) identical).

@danieldeidda @mastergari do you agree?

Note that the all other LORs in the view will be cached, and hence will be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant