fix: Drag preview issues (#905)

matthewlipski · web-flow · commit d9562a2adfab · 2024-07-03T17:55:49.000+02:00
* Changed drag preview position from `left: -100000px;` to `z-index: -1;`

* Fixed `appendChild` being called instead of `removeChild`
diff --git a/packages/core/src/editor/editor.css b/packages/core/src/editor/editor.css
@@ -62,7 +62,7 @@ Tippy popups that are appended to document.body directly
 
 .bn-drag-preview {
   position: absolute;
-  left: -100000px;
+  z-index: -1;
 }
 
 /* Give a remote user a caret */
diff --git a/packages/core/src/extensions/SideMenu/SideMenuPlugin.ts b/packages/core/src/extensions/SideMenu/SideMenuPlugin.ts
@@ -158,7 +158,7 @@ function unsetDragImage(rootEl: Document | ShadowRoot) {
     if (rootEl instanceof ShadowRoot) {
       rootEl.removeChild(dragImageElement);
     } else {
-      rootEl.body.appendChild(dragImageElement);
+      rootEl.body.removeChild(dragImageElement);
     }
 
     dragImageElement = undefined;

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ Tippy popups that are appended to document.body directly`
`62`	`62`
`63`	`63`	`.bn-drag-preview {`
`64`	`64`	`position: absolute;`
`65`		`- left: -100000px;`
	`65`	`+ z-index: -1;`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`/* Give a remote user a caret */`
Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ function unsetDragImage(rootEl: Document \| ShadowRoot) {`
`158`	`158`	`if (rootEl instanceof ShadowRoot) {`
`159`	`159`	`rootEl.removeChild(dragImageElement);`
`160`	`160`	`} else {`
`161`		`- rootEl.body.appendChild(dragImageElement);`
	`161`	`+ rootEl.body.removeChild(dragImageElement);`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`dragImageElement = undefined;`