Skip to content

Commit a29718f

Browse files
authored
fix: Address React Warning when clicking DragHandleMenuItem (#210)
1 parent b2362ff commit a29718f

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

packages/react/src/BlockSideMenu/components/DragHandleMenuItem.tsx

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,14 @@ export type DragHandleMenuItemProps = PolymorphicComponentProps<"button"> & {
55
closeMenu: () => void;
66
};
77

8-
export const DragHandleMenuItem = (props: DragHandleMenuItemProps) => (
9-
<Menu.Item
10-
{...props}
8+
export const DragHandleMenuItem = (props: DragHandleMenuItemProps) => {
9+
const {closeMenu, onClick, ...propsToPassThrough} = props;
10+
return <Menu.Item
11+
{...propsToPassThrough}
1112
onClick={(event) => {
12-
props.closeMenu();
13-
props.onClick?.(event);
13+
closeMenu();
14+
onClick?.(event);
1415
}}>
1516
{props.children}
16-
</Menu.Item>
17-
);
17+
</Menu.Item>;
18+
};

0 commit comments

Comments
 (0)