Skip to content

Commit 2b4b252

Browse files
authored
fix: upgrade prosemirror view and use correct clipboard import (#1431)
1 parent 4ea8a09 commit 2b4b252

File tree

7 files changed

+13
-17
lines changed

7 files changed

+13
-17
lines changed

package-lock.json

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@
8585
"prosemirror-state": "^1.4.3",
8686
"prosemirror-tables": "^1.6.1",
8787
"prosemirror-transform": "^1.10.2",
88-
"prosemirror-view": "^1.33.7",
88+
"prosemirror-view": "^1.38.0",
8989
"rehype-format": "^5.0.0",
9090
"rehype-parse": "^8.0.4",
9191
"rehype-remark": "^9.1.2",

packages/core/src/api/clipboard/toClipboard/copyExtension.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,7 @@ export function selectedFragmentToHTML<
129129
}
130130

131131
// Uses default ProseMirror clipboard serialization.
132-
const clipboardHTML: string = (pmView as any).__serializeForClipboard(
133-
view,
132+
const clipboardHTML: string = view.serializeForClipboard(
134133
view.state.selection.content()
135134
).dom.innerHTML;
136135

packages/core/src/blocks/TableBlockContent/TableBlockContent.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import { TableRow } from "@tiptap/extension-table-row";
55
import { Node as PMNode } from "prosemirror-model";
66
import { TableView } from "prosemirror-tables";
77

8+
import { NodeView } from "prosemirror-view";
89
import {
910
createBlockSpecFromStronglyTypedTiptapNode,
1011
createStronglyTypedTiptapNode,
@@ -101,7 +102,7 @@ export const TableBlockContent = createStronglyTypedTiptapNode({
101102
return new BlockNoteTableView(node, EMPTY_CELL_WIDTH, {
102103
...(this.options.domAttributes?.blockContent || {}),
103104
...HTMLAttributes,
104-
});
105+
}) as NodeView;
105106
};
106107
},
107108
});

packages/core/src/extensions/SideMenu/dragging.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { Node } from "prosemirror-model";
22
import { NodeSelection, Selection } from "prosemirror-state";
3-
import * as pmView from "prosemirror-view";
43
import { EditorView } from "prosemirror-view";
54

65
import { createExternalHTMLExporter } from "../../api/exporters/html/externalHTMLExporter.js";
@@ -184,10 +183,8 @@ export function dragStart<
184183
const selectedSlice = view.state.selection.content();
185184
const schema = editor.pmSchema;
186185

187-
const clipboardHTML = (pmView as any).__serializeForClipboard(
188-
view,
189-
selectedSlice
190-
).dom.innerHTML;
186+
const clipboardHTML =
187+
view.serializeForClipboard(selectedSlice).dom.innerHTML;
191188

192189
const externalHTMLExporter = createExternalHTMLExporter(schema, editor);
193190

packages/react/src/schema/ReactBlockSpec.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import {
2020
wrapInBlockStructure,
2121
} from "@blocknote/core";
2222
import {
23-
NodeView,
2423
NodeViewProps,
2524
NodeViewWrapper,
2625
ReactNodeViewRenderer,
@@ -192,7 +191,7 @@ export function createReactBlockSpec<
192191
{
193192
className: "bn-react-node-view-renderer",
194193
}
195-
)(props) as NodeView<any>;
194+
)(props);
196195

197196
if (blockConfig.isSelectable === false) {
198197
applyNonSelectableBlockFix(nodeView, this.editor);

packages/xl-multi-column/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
"prosemirror-state": "^1.4.3",
5353
"prosemirror-tables": "^1.3.7",
5454
"prosemirror-transform": "^1.9.0",
55-
"prosemirror-view": "^1.33.7",
55+
"prosemirror-view": "^1.38.0",
5656
"react-icons": "^5.2.1"
5757
},
5858
"devDependencies": {

0 commit comments

Comments
 (0)