-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect misusage of handlebars #85
Comments
As far as I know, the only reason we're seeing this happen is because the output from gscan about changing instances of I've never seen people do this before 1.0 - and all of them were following instructions from gscan. Therefore, before we add an extra check, I think the first task is to fix the instructions? |
100%. I'll added subtasks to the issue. Another case is if you are using the |
refs #85 - reduce chance that people will misusage handlebars - {{if img_url feature_image}}
refs https://github.com/TryGhost/Team/issues/41, refs TryGhost/gscan#85 - if you are using the pagination helper not inside a resource context, you will receive an error - improve error message, because it was not clear what happened - downgrade error level to normal, because it's not a critical error from Ghost's perspective, from user perspective it is - added help docs link and added a callout to our docs
refs TryGhost/Product#41, refs TryGhost/gscan#85 - if you are using the pagination helper not inside a resource context, you will receive an error - improve error message, because it was not clear what happened - downgrade error level to normal, because it's not a critical error from Ghost's perspective, from user perspective it is - added help docs link and added a callout to our docs
Steps to reproduce:
{{#if img_url feature_image}}
in your post.hbsThe if helper is an inbuilt helper of Handlebars. People sometimes misuse this helper.
Would be great to detect that in gscan.
The text was updated successfully, but these errors were encountered: