Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation Request for Stripe Checkout (Tips & Donations): pt-BR #21766

Open
1 task done
angelopublio opened this issue Nov 29, 2024 · 2 comments
Open
1 task done

Translation Request for Stripe Checkout (Tips & Donations): pt-BR #21766

angelopublio opened this issue Nov 29, 2024 · 2 comments
Labels
affects:i18n bug [triage] something behaving unexpectedly

Comments

@angelopublio
Copy link

Issue Summary

Hi there!

I wanted to reach out because I've noticed that when I use the “Tips & Donations” feature in pt-BR, the English phrase “Add a personal note” still appears. The other labels are correctly displayed in Brazilian Portuguese, but this one is still in English. It seems to be a custom field generated by Ghost when calling Stripe Checkout.

I thought it might be helpful to suggest a translation: how about “Deixar comentário” for that phrase?

If you need any more information or have questions, I'm here to help!

Best,
Angelo

ghost-stripe-checkout-tip-jar-json

ghost-stripe-checkout-tip-jar

Steps to Reproduce

  • Set the publication language to "pt-BR" in the General settings.
  • Enable the Tips & Donations feature https://ghost.org/help/tips-and-donations/.
  • Open the shareable link displayed in the Tips & Donations settings.

Ghost Version

Ghost Pro

Node.js Version

Ghost Pro

How did you install Ghost?

Ghost Pro

Database type

MySQL 5.7

Browser & OS version

No response

Relevant log / error output

No response

Code of Conduct

  • I agree to be friendly and polite to people in this repository
@github-actions github-actions bot added the needs:triage [triage] this needs to be triaged by the Ghost team label Nov 29, 2024
@cathysarisky
Copy link
Contributor

Good catch! I took a quick look, and unfortunately that string is baked into Ghost's Stripe API library. So it isn't as simple as just wrapping another string - either we punch the 't' helper into the Stripe API library (ugh), or else we pass that string in from Portal. I'm thinking passing it in from Portal is going to be the best option, since the code is already set up in Portal to translate it.

Adding this to my personal list of translation issues. Won't be this week. :)

@angelopublio
Copy link
Author

Hi Cathy,

Thank you for your prompt response!

Passing the string from the portal seems to be the best approach. I am happy to assist with testing if needed. I appreciate your efforts!

Best,
Angelo

@mike182uk mike182uk added i18n and removed needs:triage [triage] this needs to be triaged by the Ghost team labels Dec 10, 2024
@ErisDS ErisDS added bug [triage] something behaving unexpectedly affects:i18n and removed i18n labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:i18n bug [triage] something behaving unexpectedly
Projects
None yet
Development

No branches or pull requests

4 participants