-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outbound link tracking breaks special links with # #21702
Comments
Assuming the ref is still added, what URL are you expecting? The behavior seems correct: var demo = new URL('https://example.com')
demo.searchParams.set('query', 'ghost')
demo.hash = '/?key=value'
demo.toString()
// 'https://example.com/?query=ghost#/?key=value'
new URL('https://example.com/?query=ghost#/?key=value').hash
// '#/?key=value' |
I am expecting that these special links are being ignored by the ref mechanism, otherwise they simply do not work. I am unsure it is possible to implement a ref mechanism to these kind of links. |
Can you clarify what doesn't work, and where? From my example, it looks like it's behaving correctly. |
As stated in my first post, Signal and Simplex contact links do not work if the outbound link tagging is active. To check by yourself you would have to use Signal or Simplex app and see that these links work:
Whereas these one do not:
They are being opened anyway (so this is not a 404) but they do not work on Signal nor Simplex app, meaning they do not open a chat with the designated contact (me in this case). |
Thanks for sharing the full links. This looks to be an issue for URLs that directly open to an app.
|
I believe Ghost is doing the correct thing here (by appending Im not sure if we could robustly handle this - We could put logic in to check if there is a fragment and either not append the ref, or append the ref to a querystring embedded in the fragment, but this would break functionality for users that do want the original behaviour because they are not using the fragment for any type of routing |
Issue Summary
Same as the the closed issue 20492
I have a few links that directly open a chat with me on Signal and SimpleX apps. Ghost puts ?ref=mydomain.com there, breaking the functionality.
Example of correct link, as seen in the Editor page:
The same link in the published page (notice the ref somewhere at the beginning):
Simple solution: disable outbound links tracking in specified single pages (a toggle on the right sidebar)
Complete solution: find a way to recognize this special links with #
Steps to Reproduce
Ghost Version
5.101.1
Node.js Version
not sure
How did you install Ghost?
PikaPods
Database type
MySQL 5.7
Browser & OS version
Firefox on Fedora 41
Relevant log / error output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: