Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding torrents opens multiple Tribler browser tabs #8379

Closed
teddyrogers opened this issue Jan 10, 2025 · 3 comments · Fixed by #8442
Closed

Adding torrents opens multiple Tribler browser tabs #8379

teddyrogers opened this issue Jan 10, 2025 · 3 comments · Fixed by #8442
Assignees
Milestone

Comments

@teddyrogers
Copy link

Tribler 8.0.7, if Tribler is open in a browser tab and I click on a .torrent file a new browser tab is opened with another Tribler page.

Is it possible to prevent this behaviour, stop multiple tabs and Tribler pages from opening if one already exists?

@qstokkink qstokkink added this to the 8.1.0 milestone Jan 13, 2025
@qstokkink
Copy link
Contributor

qstokkink commented Feb 18, 2025

I think there's an elegant way to avoid multiple tabs by adding the number of existing sessions to the initial core connection message, here:

"kwargs": {"public_key": self.public_key or "", "version": v}

I'll give it a shot.

UPDATE: Above is not a good idea. The events endpoint streams in bytes, it's not a good solution to get just a single "alive" message (without a streaming protocol).

@teddyrogers
Copy link
Author

teddyrogers commented Feb 18, 2025

Could you do this through JavaScript using localStorage (or even a cookie) and checking on page load/ unload with a session key/ hash?

@qstokkink
Copy link
Contributor

We could technically use that information. However, the solution of #8442 avoids talking to the GUI altogether, which is faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants